Page MenuHomePhabricator

Minerva bundle checks are broken
Closed, ResolvedPublic2 Estimated Story Points

Description

The Minerva bundlesize checks are broken and do not run on commits so are currently pretty useless.

I see two options here

  1. We copy across the Vector scripts to Minerva and use them
  2. We remove the code from the codebase.

Personally option 1 seems preferable as we do care about monitoring bundle sizes and this reduces the risk of retroactively detecting them as part of chores.

Details

Event Timeline

Change 615813 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Run bundlesize tests on every commit

https://gerrit.wikimedia.org/r/615813

Change 615813 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Run bundlesize tests on every commit

https://gerrit.wikimedia.org/r/615813