Page MenuHomePhabricator

[Regression] UI regressions in VE on Beta cluster
Closed, DuplicatePublic

Description

I am noticing lots of UI regressions in VE on Beta cluster. I am not using Legacy Vector. Not sure whether any of these are intentional changes.

  1. There is an extra line appearing at the end of the article.
    Screen Shot 2020-07-28 at 3.50.53 PM.png (760×2 px, 163 KB)
  1. The tab highlights are not covering the menu items completely.
    Screen Shot 2020-07-28 at 3.50.40 PM.png (340×1 px, 132 KB)
    Screen Shot 2020-07-28 at 3.50.31 PM.png (344×1 px, 113 KB)
  1. There is a big gap from the left border of the page to the content block of the page.

Beta cluster:

Screen Shot 2020-07-28 at 3.51.12 PM.png (976×568 px, 224 KB)

Other wikis:
Screen Shot 2020-07-28 at 3.53.11 PM.png (1×632 px, 213 KB)

Event Timeline

All of these appear to be problems with the new version of Vector only, right?

JTannerWMF added subscribers: ovasileva, JTannerWMF.

Hey @ovasileva , it appears the Web team caused some regressions. Can our (the Web team) engineers break down these tickets and fix the appropriate bugs.

ovasileva triaged this task as Medium priority.Jul 29 2020, 6:21 PM

A couple of these are by design:

  1. There is an extra line appearing at the end of the article.
    Screen Shot 2020-07-28 at 3.50.53 PM.png (760×2 px, 163 KB)
    • this is to separate the footer from the rest of the page. In the past, this line was blue.
  1. The tab highlights are not covering the menu items completely.
    Screen Shot 2020-07-28 at 3.50.40 PM.png (340×1 px, 132 KB)
    Screen Shot 2020-07-28 at 3.50.31 PM.png (344×1 px, 113 KB)
    • This seems to be a bug
  1. There is a big gap from the left border of the page to the content block of the page.

Beta cluster:

Screen Shot 2020-07-28 at 3.51.12 PM.png (976×568 px, 224 KB)

Other wikis:
Screen Shot 2020-07-28 at 3.53.11 PM.png (1×632 px, 213 KB)

  • This one is also expected

Note that the toolbar doesn't left align with the tabs when it should:

image.png (453×198 px, 15 KB)

I also thinks it's odd that the "Article" tab and the toolbar are open-ended and have no left border:

image.png (161×387 px, 16 KB)

Everywhere else the toolbar has a left border, e.g. VE on tablets

image.png (136×413 px, 5 KB)

This context (quoted below) is helpful – thank you, Olga. Confirming a few things in line below...

A couple of these are by design:

  1. There is an extra line appearing at the end of the article.
    • this is to separate the footer from the rest of the page. In the past, this line was blue.

Understood; resulting action = none.

  1. The tab highlights are not covering the menu items completely.
    Screen Shot 2020-07-28 at 3.50.40 PM.png (340×1 px, 132 KB)
    Screen Shot 2020-07-28 at 3.50.31 PM.png (344×1 px, 113 KB)
    • This seems to be a bug

@ovasileva, would you like us to create a new ticket for the above issue as a child of T259083?
Resulting action = Web Team to fix; TBD which ticket this work will happen in .

  1. There is a big gap from the left border of the page to the content block of the page.
  2. This one is also expected

Understood; resulting action = none.

ppelberg added a subscriber: iamjessklein.

Good spots, Ed. I've created tickets for the issues you raised in T259083#6348592:

IssueTicketPriority
VE's toolbar doesn't left align with the Article / Discussion tabsT259272Medium
Article tab and the toolbar have no left borderT259273TBD; I'm curious what @iamjessklein thinks.
This comment was removed by ovasileva.

Arguably T259272 and T259331 are the same in that they are a result of the toolbar margins not being set correctly (the fix will in the same line of CSS).

Curious what @alexhollender is thinking regarding the approach to the borders on the page.

I've merged this into T259331 because:

  1. There is an extra line appearing at the end of the article

this is expected, the line is from the footer

  1. The tab highlights are not covering the menu items completely

this is covered in T259331

  1. There is a big gap from the left border of the page to the content block of the page.

this is covered in T259761