Page MenuHomePhabricator

Fix broken NameTableStoreTest case on Sqlite
Open, Needs TriagePublic

Description

Tue Jul 28 20:30:44 UTC 2020	b69e3c648306	wikidb-unittest_	Error 19 from MediaWiki\Storage\NameTableStore::retryStore, UNIQUE constraint failed: unittest_slot_roles.role_id INSERT INTO unittest_slot_roles (role_name,role_id) VALUES ('foo',1) localhost
#0 /workspace/src/includes/libs/rdbms/database/Database.php(1654): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(2339): Wikimedia\Rdbms\Database->query(string, string, integer)
#3 /workspace/src/includes/libs/rdbms/database/Database.php(2319): Wikimedia\Rdbms\Database->doInsert(string, array, string)
#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->insert(string, array, string)
#5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(369): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#6 /workspace/src/includes/Storage/NameTableStore.php(466): Wikimedia\Rdbms\DBConnRef->insert(string, array, string)
#7 /workspace/src/includes/libs/rdbms/database/Database.php(4457): MediaWiki\Storage\NameTableStore->MediaWiki\Storage\{closure}(Wikimedia\Rdbms\DatabaseSqlite, string)
#8 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->doAtomicSection(string, Closure, string)
#9 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(641): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#10 /workspace/src/includes/Storage/NameTableStore.php(487): Wikimedia\Rdbms\DBConnRef->doAtomicSection(string, Closure, string)
#11 /workspace/src/includes/Storage/NameTableStore.php(433): MediaWiki\Storage\NameTableStore->retryStore(Wikimedia\Rdbms\DBConnRef, string, integer)
#12 [internal function]: MediaWiki\Storage\NameTableStore->MediaWiki\Storage\{closure}(integer, Wikimedia\Rdbms\DatabaseSqlite)
#13 /workspace/src/includes/libs/rdbms/database/Database.php(4102): call_user_func(Closure, integer, Wikimedia\Rdbms\DatabaseSqlite)
#14 /workspace/src/includes/libs/rdbms/database/Database.php(4653): Wikimedia\Rdbms\Database->runOnTransactionIdleCallbacks(integer)
#15 /workspace/src/tests/phpunit/includes/Storage/NameTableStoreTest.php(453): Wikimedia\Rdbms\Database->rollback(string)
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1415): MediaWiki\Tests\Storage\NameTableStoreTest->testTransactionRollbackWithInterference()
#17 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1035): PHPUnit\Framework\TestCase->runTest()
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(763): PHPUnit\Framework\TestResult->run(MediaWiki\Tests\Storage\NameTableStoreTest)
#20 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(446): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#22 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#23 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#24 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(627): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#25 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(204): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, array, boolean)
#26 /workspace/src/tests/phpunit/phpunit.php(75): PHPUnit\TextUI\Command->run(array, boolean)
#27 /workspace/src/maintenance/doMaintenance.php(107): PHPUnitMaintClass->execute()
#28 /workspace/src/tests/phpunit/phpunit.php(134): require(string)
#29 {main}

Event Timeline

Change 616953 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Storage: Disable NameTableStoreTest case that fails on sqlite

https://gerrit.wikimedia.org/r/616953

Change 616953 merged by jenkins-bot:
[mediawiki/core@master] Storage: Disable NameTableStoreTest case that fails on sqlite

https://gerrit.wikimedia.org/r/616953

Change 616940 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_35] Storage: Disable NameTableStoreTest case that fails on sqlite

https://gerrit.wikimedia.org/r/616940

Change 616940 merged by Krinkle:
[mediawiki/core@REL1_35] Storage: Disable NameTableStoreTest case that fails on sqlite

https://gerrit.wikimedia.org/r/616940