Page MenuHomePhabricator
Create Task
Maniphest T259086

Remove obsolete 'set-graphics'/'svg2png'/'imagemin' tasks and Less background-image raster fallback for former Grade C browser support
Closed, ResolvedPublic
Actions

Description

With

there's no need for 'svg2png' task in OOUI anymore.

  • Remove 'set-graphics'/'svg2png' task
    • Remove 'grunt-svg2png' package
    • Remove 'imagemin' task – it cares only about raster images
  • Remove raster fallback .oo-ui-background-image-svg-internal()

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.40.0mediawiki/coremaster+1 K -4 K
[BREAKING CHANGE] build: Remove PNG fallback, composition and optimizationoojs/uimaster+8 K -11 K
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Jul 28 2020, 11:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2020, 11:32 PM
Volker_E renamed this task from Remove obsolete 'svg2png' task for former Grade C browser support to Remove obsolete 'set-graphics'/'svg2png' task and Less background-image raster fallback for former Grade C browser support.Jul 28 2020, 11:45 PM
Volker_E updated the task description. (Show Details)
Volker_E renamed this task from Remove obsolete 'set-graphics'/'svg2png' task and Less background-image raster fallback for former Grade C browser support to Remove obsolete 'set-graphics'/'svg2png'/'imagemin' tasks and Less background-image raster fallback for former Grade C browser support.Jul 29 2020, 12:13 AM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Jul 29 2020, 12:30 AM

Change 616958 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [BREAKING CHANGE] build: Remove PNG fallback, composition and optimization

https://gerrit.wikimedia.org/r/616958

gerritbot added a project: Patch-For-Review.Jul 29 2020, 12:30 AM
gerritbot added a comment.Jul 29 2020, 9:12 AM

Change 616958 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] build: Remove PNG fallback, composition and optimization

https://gerrit.wikimedia.org/r/616958

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 10:10 AM
Volker_E closed this task as Resolved.Jul 30 2020, 8:57 PM
Volker_E claimed this task.
Volker_E triaged this task as High priority.
Volker_E moved this task from Backlog to OOUI-0.40.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.40.0); removed OOUI.
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Jul 31 2020, 2:31 AM

Change 617589 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.0

https://gerrit.wikimedia.org/r/617589

gerritbot added a project: Patch-For-Review.Jul 31 2020, 2:31 AM
gerritbot added a comment.Aug 5 2020, 9:56 PM

Change 617589 abandoned by Jforrester:
[mediawiki/core@master] Update OOUI to v0.40.0

Reason:
Going straight to 0.40.1.

https://gerrit.wikimedia.org/r/617589

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL