Page MenuHomePhabricator

Failing test RequestFromGlobalsTest
Closed, ResolvedPublic

Description

Travis CI failing at https://travis-ci.com/github/wikimedia/mediawiki/builds
since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/610034 (ref T256831).

Presumably reproducible locally as well and e.g. if WMF CI were to internally use a different port at some point.

There was 1 failure:

1) RequestFromGlobalsTest::testGetUri2

Failed asserting that '//:9412/test.php/page/1:1' matches expected GuzzleHttp\Psr7\Uri Object &000000007694634d000000001369345a (
    'scheme' => ''
    'userInfo' => ''
    'host' => ''
    'port' => null
    'path' => '/test.php/page/1:1'
    'query' => ''
    'fragment' => ''
)

/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Rest/RequestFromGlobalsTest.php:59

Event Timeline

The stubbed port is being dropped for some reason, presumably because WebRequest::getGlobalRequestURL() does not ask for the port from that index, otherwise it should have worked even though it's the same as the hardcored CI value. It needs to be added now in the REQUEST_URI index, instead of to the SERVER_PORT index. The port and path would be later sorted out by parse_url().

Change 617066 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Fix RequestFromGlobalsTest failing in Travis CI

https://gerrit.wikimedia.org/r/617066

CCicalese_WMF edited subscribers, added: CCicalese_WMF; removed: cicalese.

Fixing to subscribe my staff account rather than my volunteer account.

@Krinkle, since you tagged me in particular in the task creation in addition to tagging the Platform Engineering team, was there an action you were requesting from me?

Since Travis CI clearly can give different test results than Wikimedia CI, is there a way for us on the Platform Engineering team to have the benefit of those test results before merging patches?

@Ammarpad, thank you very much for the updated patch. I'm putting it in the Clinic Duty code review queue.

Fixing to subscribe my staff account rather than my volunteer account.

Sorry, autocompete fail!

@Krinkle, since you tagged me in particular in the task creation in addition to tagging the Platform Engineering team, was there an action you were requesting from me?

No, look like @Ammarpad is on it already. I tagged you as reviewer/approver of the commit in question since an author of a commit isn't always around or available and/or may not be able or expected to be able to priotize it (esp as volunteer).

Change 617066 merged by jenkins-bot:
[mediawiki/core@master] Fix RequestFromGlobalsTest failing in Travis CI

https://gerrit.wikimedia.org/r/617066

Travis is now passing, @Krinkle. I think this is resolved now, but not sure if there's anything else.

Change 624701 had a related patch set uploaded (by Reedy; owner: Ammarpad):
[mediawiki/core@REL1_35] Fix RequestFromGlobalsTest failing in Travis CI

https://gerrit.wikimedia.org/r/624701

Change 624701 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix RequestFromGlobalsTest failing in Travis CI

https://gerrit.wikimedia.org/r/624701