OAuth extension - remove unused TYPE_PROFILE constant in the Resource class.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Art.tsymbar
	Jul 29 2020, 10:35 AM

Description

TYPE_PROFILE constant is to be removed in the Resource.php as it is not used anywhere.

Details

	Subject	Repo	Branch	Lines +/-
	Resource: add two private consts and replace string literals with them	mediawiki/extensions/OAuth	master	+14 -5
	Resource: OAuth extension - remove unused TYPE_PROFILE constant in the Resource class	mediawiki/extensions/OAuth	master	+0 -1

Customize query in gerrit

Event Timeline

Art.tsymbar created this task.Jul 29 2020, 10:35 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 10:35 AM

Helga_sf triaged this task as High priority.Jul 29 2020, 2:49 PM

Helga_sf lowered the priority of this task from High to Low.

Helga_sf added a project: Platform Team Workboards (S&F Workboard).

Vlad.shapik claimed this task.Sep 28 2020, 3:00 PM

Vlad.shapik moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.

Change 630645 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/OAuth@master] Resource: OAuth extension - remove unused TYPE_PROFILE constant in the Resource class

https://gerrit.wikimedia.org/r/630645

gerritbot added a project: Patch-For-Review.Sep 28 2020, 5:08 PM

Change 630810 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/OAuth@master] Resource: add two private consts and replace string literals with them

https://gerrit.wikimedia.org/r/630810

Change 630645 abandoned by Vlad.shapik:
[mediawiki/extensions/OAuth@master] Resource: OAuth extension - remove unused TYPE_PROFILE constant in the Resource class

Reason:
Abandon from this patch, because I create new patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/ /630810 with right formulation of the problem.

https://gerrit.wikimedia.org/r/630645

Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 1 2020, 11:23 AM

Change 630810 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Resource: add two private consts and replace string literals with them

https://gerrit.wikimedia.org/r/630810

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 5 2020, 3:00 PM

Vlad.shapik moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Oct 6 2020, 10:30 AM

Reedy closed this task as Resolved.Oct 25 2020, 8:32 PM

OAuth extension - remove unused TYPE_PROFILE constant in the Resource class.Closed, ResolvedPublicActions

Description

Details

Event Timeline

OAuth extension - remove unused TYPE_PROFILE constant in the Resource class.
Closed, ResolvedPublic
Actions