Page MenuHomePhabricator

OOUI *MultiselectWidgets (inputs) have unwanted margin on Timeless
Closed, ResolvedPublic

Description

Example on Special:Block (there are other places, like Special:PageTranslation as well) on Timeless:

image.png (1,912×1,564 px, 276 KB)

Expected rendering on Vector:

image.png (1,902×1,584 px, 337 KB)

The margin comes from this code in Timeless:

	form input {
	  margin: 0.5em 0;
	  padding: 0.34em;
	}

I believe the other inputs explicitly override margin, so this issue does not appear for them.

Details

Related Changes in Gerrit:

Event Timeline

Nikerabbit renamed this task from OOUI *MultiselectWidgets (textareas) have unwanted margin on Timeless to OOUI *MultiselectWidgets (inputs) have unwanted margin on Timeless.

Change 649677 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Clean up forms some more

https://gerrit.wikimedia.org/r/649677

Change 649677 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Clean up forms some more

https://gerrit.wikimedia.org/r/649677

Isarra claimed this task.

QA: Confirmed on translatewiki.net