Page MenuHomePhabricator
Create Task
Maniphest T259137

Avoid outputting invalid lang="qqq" on Special:Translations and Special:SupportedLanguages
Closed, ResolvedPublicBUG REPORT
Actions

Description

Both these pages output lang="qqq" which was flagged by Lighthouse as invalid. For items depicting Message Documentation, the language code of content language should be used.

Place to fix:

  • lang attribute in SpecialTranslations::showTranslations
  • lang attribute in SpecialSupportedLanguage::outputLanguageCloud

Make sure you have $wgTranslateDocumentationLanguageCode = 'qqq'; set in LocalSettings.php. Create for example a translatable page and add message documentation for it.

Documentation:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Special:ActiveLanguages: Fix lang attribute for message documentationmediawiki/extensions/Translatemaster+16 -3
Special:Translations: Fix lang attribute for message documentationmediawiki/extensions/Translatemaster+1 -1
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Jul 29 2020, 2:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 2:55 PM
Nikerabbit changed the subtype of this task from "Task" to "Bug Report".Dec 10 2020, 11:53 AM
Nikerabbit triaged this task as Low priority.Dec 10 2020, 11:58 AM
Nikerabbit added a project: good first task.
Nikerabbit updated the task description. (Show Details)
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 24 2021, 10:55 AM
• JCarvalho changed the task status from Open to In Progress.Sep 30 2021, 2:28 PM
• JCarvalho claimed this task.
gerritbot added a comment.Oct 8 2021, 5:28 PM

Change 727430 had a related patch set uploaded (by JCarvalho; author: João Carvalho):

[mediawiki/extensions/Translate@master] Fix Special:Translations lang attribute on Message documentation area

https://gerrit.wikimedia.org/r/727430

gerritbot added a project: Patch-For-Review.Oct 8 2021, 5:28 PM
gerritbot added a comment.Oct 11 2021, 7:28 PM

Change 730040 had a related patch set uploaded (by JCarvalho; author: JCarvalho):

[mediawiki/extensions/Translate@master] Special:ActiveLanguages: Fix lang attribute for message documentation

https://gerrit.wikimedia.org/r/730040

gerritbot added a comment.Oct 12 2021, 8:03 AM

Change 727430 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:Translations: Fix lang attribute for message documentation

https://gerrit.wikimedia.org/r/727430

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 12 2021, 3:00 PM
Nikerabbit added a comment.Oct 13 2021, 12:10 PM

The patch for Special:Translations was deployed to translatewiki.net and tested there. Looks good.

gerritbot added a comment.Oct 25 2021, 9:29 AM

Change 730040 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:ActiveLanguages: Fix lang attribute for message documentation

https://gerrit.wikimedia.org/r/730040

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 2021-10-26); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 25 2021, 10:00 AM
Nikerabbit closed this task as Resolved.Nov 10 2021, 1:09 PM
Nikerabbit removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits