Make img_lossy case-sensitive like the rest of the img_ options
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Jul 29 2020, 5:35 PM

Description

Some discussion in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/593576/5/tests/phpunit/Parsoid/Config/SiteConfigTest.php#315

All of the img_* options (right, left, etc) are case-sensitive (only lower-case allowed) *except* for img_lossy, which is case-insensitive (lossy, LOSSY, lOsSy etc allowed).

We should make img_lossy case-sensitive for consistency. (Or we could make all the options case-insensitive, but I don't see a strong reason to do that.)

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Bump parsoid to 0.14.0-a17	mediawiki/vendor	master	+207 -190
Update tests now that img_lossy is case sensitive	mediawiki/services/parsoid	master	+3 -3
Make img_lossy case-sensitive	mediawiki/extensions/PagedTiffHandler	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T289330: Legacy parser generates different output on RTL wikis for left/right aligned images compared to LTR wkis but Parsoid does not
T257629: Followup on bugs exposed by SiteConfig Unit Tests patch
Mentioned Here: T216566: Capitalized versions of valid File options are usually ignored, but are not flagged as Linter bogus file options.

Event Timeline

cscott created this task.Jul 29 2020, 5:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 5:35 PM

Change 617192 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PagedTiffHandler@master] Make img_lossy case-sensitive

https://gerrit.wikimedia.org/r/617192

gerritbot added a project: Patch-For-Review.Jul 29 2020, 5:40 PM

cscott mentioned this in T257629: Followup on bugs exposed by SiteConfig Unit Tests patch.Jul 29 2020, 5:43 PM

Change 617192 merged by jenkins-bot:
[mediawiki/extensions/PagedTiffHandler@master] Make img_lossy case-sensitive

https://gerrit.wikimedia.org/r/617192

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 29 2020, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 7:10 PM

ssastry triaged this task as Medium priority.Aug 5 2020, 9:40 PM

ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.

Arlolra mentioned this in T289330: Legacy parser generates different output on RTL wikis for left/right aligned images compared to LTR wkis but Parsoid does not.Aug 20 2021, 11:21 PM

Is this related to T216566? The image option "Border" appears to be case-insensitive, but "Thumb" works only when it is lower-case.

Change 714436 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Update tests now that img_lossy is case sensitive

https://gerrit.wikimedia.org/r/714436

gerritbot added a project: Patch-For-Review.Aug 23 2021, 11:35 PM

@Jonesey95 Related, yes, but should have been resolved when the patch merged in T259165#6346173

Change 714436 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Update tests now that img_lossy is case sensitive

https://gerrit.wikimedia.org/r/714436

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2021, 4:10 AM

Change 715581 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump parsoid to 0.14.0.a17

https://gerrit.wikimedia.org/r/715581

gerritbot added a project: Patch-For-Review.Aug 30 2021, 7:05 PM

Change 715581 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.14.0-a17