Page MenuHomePhabricator

MediaWiki::restInPeace: transaction round 'UpdateBetaFeatureUserCountsJob::run' still running
Open, Needs TriagePublic

Description

Error

exception.class Wikimedia\Rdbms\DBTransactionError

MediaWiki version: 1.36.0-wmf.2

message
MediaWiki::restInPeace: transaction round 'UpdateBetaFeatureUserCountsJob::run' still running

Impact

Notes

Seems recent. 40 occurrences on muswiki on 2020-07-29 as of this report.

Details

Request ID
40ec34bcab3904b6b0f9ff32
Request URL
https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(1101): Wikimedia\Rdbms\LBFactory->commitMasterChanges(string)
#1 /srv/mediawiki/rpc/RunSingleJob.php(93): MediaWiki->restInPeace()
#2 {main}

Event Timeline

BPirkle created this task.Wed, Jul 29, 6:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jul 29, 6:24 PM
BPirkle updated the task description. (Show Details)Wed, Jul 29, 6:25 PM

muswiki was made read-only temporarily, which probably caused a spike of errors like this.

@Jdforrester-WMF so not likely to happen again, and we can close this and not have it as a blocker?

@Jdforrester-WMF so not likely to happen again, and we can close this and not have it as a blocker?

Yes. Though jobs really should behave gracefully when a wiki goes read-only, that's a wider problem.

We have regular (brief) moments of automatically induced read-only mode on even the busiest wikis but this error hasn't shown up there for other jobs.

So I suspect there might be a bug in the UpdateBetaFeatureUserCountsJob class specifically withit opening a transaction it doesn't own and/or is catching a db error without closing the transaction etc.,

brennen added a subscriber: brennen.

For clarity, removing as a blocker.