exception.class Wikimedia\Rdbms\DBTransactionError
MediaWiki version: 1.36.0-wmf.2
MediaWiki::restInPeace: transaction round 'UpdateBetaFeatureUserCountsJob::run' still running
Seems recent. 40 occurrences on muswiki on 2020-07-29 as of this report.
#0 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(1101): Wikimedia\Rdbms\LBFactory->commitMasterChanges(string)
#1 /srv/mediawiki/rpc/RunSingleJob.php(93): MediaWiki->restInPeace()
#2 {main}muswiki was made read-only temporarily, which probably caused a spike of errors like this.
@Jdforrester-WMF so not likely to happen again, and we can close this and not have it as a blocker?
Yes. Though jobs really should behave gracefully when a wiki goes read-only, that's a wider problem.
We have regular (brief) moments of automatically induced read-only mode on even the busiest wikis but this error hasn't shown up there for other jobs.
So I suspect there might be a bug in the UpdateBetaFeatureUserCountsJob class specifically withit opening a transaction it doesn't own and/or is catching a db error without closing the transaction etc.,
No longer seen in the last 90 days. Confirmed that underlying error detection does still exist in LBFactory and uses the same message still (Codesearch), and would thus match if it was still triggered.