Use of Article::prepareContentForEdit was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.1

exception.class ErrorException

message

Use of Article::prepareContentForEdit was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute]

Impact

Notes

Details

Request ID: d5e0ecd6-eade-40d1-b9b6-3371cbfffc79
Request URL: https://en.wikipedia.org/wiki/Special:AbuseLog/7998587

Stack Trace

exception.trace

#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.36.0-wmf.1/includes/debug/MWDebug.php(329): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.36.0-wmf.1/includes/debug/MWDebug.php(305): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.36.0-wmf.1/includes/debug/MWDebug.php(234): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.36.0-wmf.1/includes/GlobalFunctions.php(1028): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.36.0-wmf.1/includes/page/Article.php(2950): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/AFComputedVariable.php(241): Article->prepareContentForEdit(WikitextContent)
#7 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(124): AFComputedVariable->compute(AbuseFilterVariableHolder)
#8 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(233): AbuseFilterVariableHolder->getVar(string)
#9 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(660): AbuseFilterVariableHolder->dumpAllVars(boolean)
#10 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(131): SpecialAbuseLog->showDetails(string)
#11 /srv/mediawiki/php-1.36.0-wmf.1/includes/specialpage/SpecialPage.php(600): SpecialAbuseLog->execute(string)
#12 /srv/mediawiki/php-1.36.0-wmf.1/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(string)
#13 /srv/mediawiki/php-1.36.0-wmf.1/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#14 /srv/mediawiki/php-1.36.0-wmf.1/includes/MediaWiki.php(940): MediaWiki->performRequest()
#15 /srv/mediawiki/php-1.36.0-wmf.1/includes/MediaWiki.php(543): MediaWiki->main()
#16 /srv/mediawiki/php-1.36.0-wmf.1/index.php(53): MediaWiki->run()
#17 /srv/mediawiki/php-1.36.0-wmf.1/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	PRODUCTION ERROR	Daimona	T259180 Use of Article::prepareContentForEdit was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute]
Resolved		Urbanecm	T246539 Dry-run, then actually run updateVarDumps
Declined		Daimona	T246938 How to update/delete ExternalStore entries?
Resolved		Daimona	T252696 Find a good way to run the updateVarDumps script on large wikis

Event Timeline

BPirkle created this task.Jul 29 2020, 6:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 6:41 PM

See related discussion in https://phabricator.wikimedia.org/T251278#6157584

Daimona mentioned this in T259181: Use of Revision::getId was deprecated in MediaWiki 1.31. [Called from MediaWiki\Storage\DerivedPageDataUpdater::grabCurrentRevision].Jul 29 2020, 10:01 PM

• eprodromou triaged this task as Low priority.Aug 4 2020, 8:25 PM

• eprodromou edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

• eprodromou moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

Krinkle moved this task from Untriaged to Aug 2020 on the Wikimedia-production-error board.Aug 26 2020, 7:03 PM

Seen again today happening in: Use of Article::getContentModel was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute]

#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.36.0-wmf.10/includes/debug/MWDebug.php(329): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.36.0-wmf.10/includes/debug/MWDebug.php(305): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.36.0-wmf.10/includes/debug/MWDebug.php(234): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.36.0-wmf.10/includes/GlobalFunctions.php(1029): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.36.0-wmf.10/includes/page/Article.php(2574): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.36.0-wmf.10/extensions/AbuseFilter/includes/AFComputedVariable.php(242): Article->getContentModel()
#7 /srv/mediawiki/php-1.36.0-wmf.10/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(127): AFComputedVariable->compute(AbuseFilterVariableHolder)
#8 /srv/mediawiki/php-1.36.0-wmf.10/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(246): AbuseFilterVariableHolder->getVar(string)
#9 /srv/mediawiki/php-1.36.0-wmf.10/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(697): AbuseFilterVariableHolder->dumpAllVars(boolean)
#10 /srv/mediawiki/php-1.36.0-wmf.10/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(143): SpecialAbuseLog->showDetails(string)
#11 /srv/mediawiki/php-1.36.0-wmf.10/includes/specialpage/SpecialPage.php(600): SpecialAbuseLog->execute(string)
#12 /srv/mediawiki/php-1.36.0-wmf.10/includes/specialpage/SpecialPageFactory.php(692): SpecialPage->run(string)
#13 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#14 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(940): MediaWiki->performRequest()
#15 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(543): MediaWiki->main()
#16 /srv/mediawiki/php-1.36.0-wmf.10/index.php(53): MediaWiki->run()
#17 /srv/mediawiki/php-1.36.0-wmf.10/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}

Daimona added a subtask: T246539: Dry-run, then actually run updateVarDumps.Sep 30 2020, 6:44 PM

Tagging with MW-1.36-release, because Article::prepareContentForEdit() should be removed in 1.36, and we can't as long as it's still used.

The relevant code has the following comment:

// @fixme TEMPORARY WORKAROUND FOR T187153

T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null)

daniel mentioned this in T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).Nov 18 2020, 7:37 PM

Reedy merged a task: T269316: Use of Article::prepareContentForEdit was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute].Dec 3 2020, 2:15 AM

Reedy added a subscriber: Reedy.

Urbanecm closed subtask T246539: Dry-run, then actually run updateVarDumps as Resolved.Dec 8 2020, 5:12 PM

Daimona closed this task as Resolved.Dec 8 2020, 5:14 PM

Daimona claimed this task.

Use of Article::prepareContentForEdit was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute]Closed, ResolvedPublicPRODUCTION ERRORActions