Page MenuHomePhabricator
Create Task
Maniphest T259181

Use of Revision::getId was deprecated in MediaWiki 1.31. [Called from MediaWiki\Storage\DerivedPageDataUpdater::grabCurrentRevision]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.1

exception.class ErrorException

message
Use of Revision::getId was deprecated in MediaWiki 1.31. [Called from MediaWiki\Storage\DerivedPageDataUpdater::grabCurrentRevision]

Impact

Notes

Details

Request ID
a3846f0a-81c6-4722-92da-11ee7d445f67
Request URL
https://ru.wikipedia.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%96%D1%83%D1%80%D0%BD%D0%B0%D0%BB_%D0%B7%D0%BB%D0%BE%D1%83%D0%BF%D0%BE%D1%82%D1%80%D0%B5%D0%B1%D0%BB%D0%B5%D0%BD%D0%B8%D0%B9/954362
Stack Trace
exception.trace
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.36.0-wmf.1/includes/debug/MWDebug.php(329): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.36.0-wmf.1/includes/debug/MWDebug.php(305): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.36.0-wmf.1/includes/debug/MWDebug.php(234): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.36.0-wmf.1/includes/GlobalFunctions.php(1028): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.36.0-wmf.1/includes/Revision.php(461): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.36.0-wmf.1/includes/Storage/DerivedPageDataUpdater.php(549): Revision->getId()
#7 /srv/mediawiki/php-1.36.0-wmf.1/includes/Storage/DerivedPageDataUpdater.php(776): MediaWiki\Storage\DerivedPageDataUpdater->grabCurrentRevision()
#8 /srv/mediawiki/php-1.36.0-wmf.1/includes/page/WikiPage.php(2112): MediaWiki\Storage\DerivedPageDataUpdater->prepareContent(User, MediaWiki\Storage\RevisionSlotsUpdate, boolean)
#9 /srv/mediawiki/php-1.36.0-wmf.1/includes/page/Article.php(2953): WikiPage->prepareContentForEdit(WikitextContent, NULL, User, NULL, boolean)
#10 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/AFComputedVariable.php(241): Article->prepareContentForEdit(WikitextContent)
#11 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(124): AFComputedVariable->compute(AbuseFilterVariableHolder)
#12 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(233): AbuseFilterVariableHolder->getVar(string)
#13 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(660): AbuseFilterVariableHolder->dumpAllVars(boolean)
#14 /srv/mediawiki/php-1.36.0-wmf.1/extensions/AbuseFilter/includes/special/SpecialAbuseLog.php(131): SpecialAbuseLog->showDetails(string)
#15 /srv/mediawiki/php-1.36.0-wmf.1/includes/specialpage/SpecialPage.php(600): SpecialAbuseLog->execute(string)
#16 /srv/mediawiki/php-1.36.0-wmf.1/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(string)
#17 /srv/mediawiki/php-1.36.0-wmf.1/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#18 /srv/mediawiki/php-1.36.0-wmf.1/includes/MediaWiki.php(940): MediaWiki->performRequest()
#19 /srv/mediawiki/php-1.36.0-wmf.1/includes/MediaWiki.php(543): MediaWiki->main()
#20 /srv/mediawiki/php-1.36.0-wmf.1/index.php(53): MediaWiki->run()
#21 /srv/mediawiki/php-1.36.0-wmf.1/index.php(46): wfIndexMain()
#22 /srv/mediawiki/w/index.php(3): require(string)
#23 {main}
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Introduce and apply NonSerializableTraitDaniel Kinzlermediawiki/coremaster+65 -29
Allow for safe deserialization of WikiPage objects.Daniel Kinzlermediawiki/coremaster+14 -0
Customize query in gerrit

Related Objects

Event Timeline

BPirkle created this task.Jul 29 2020, 6:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 6:43 PM
• Pchelolo assigned this task to DannyS712.Jul 29 2020, 8:26 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 29 2020, 8:26 PM
Maintenance_bot moved this task from Unsorted to Abuse Filter on the User-DannyS712 board.Jul 29 2020, 9:15 PM
DannyS712 moved this task from Abuse Filter to In progress on the User-DannyS712 board.Jul 29 2020, 9:42 PM

Thats fun. Looking

DannyS712 added a subscriber: • Pchelolo.Jul 29 2020, 9:50 PM

Okay, this shouldn't be happening.

#6 /srv/mediawiki/php-1.36.0-wmf.1/includes/Storage/DerivedPageDataUpdater.php(549): Revision->getId()
#7 /srv/mediawiki/php-1.36.0-wmf.1/includes/Storage/DerivedPageDataUpdater.php(776): MediaWiki\Storage\DerivedPageDataUpdater->grabCurrentRevision()

Relevant code is

grabCurrentRevision
$current = $wikiPage->getRevisionRecord();

$this->pageState = [
	'oldRevision' => $current,
	'oldId' => $current ? $current->getId() : 0, // <--- THIS IS LINE 549 calling Revision::getId
	'oldIsRedirect' => $wikiPage->isRedirect(), // NOTE: uses page table
	'oldCountable' => $wikiPage->isCountable(), // NOTE: uses pagelinks table
];

So apparently WikiPage::getRevisionRecord somehow returns a Revision object?
Since Revision::__construct also emits deprecation warnings, can someone (@BPirkle @Pchelolo) check where the Revision object is actually being created?

Daimona subscribed.Jul 29 2020, 10:01 PM

It's the same as T259180.

• eprodromou triaged this task as Low priority.Aug 4 2020, 8:23 PM
• eprodromou edited projects, added: Platform Team Workboards (Clinic Duty Team); removed: Platform Engineering.
• eprodromou moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.
brennen added a project: User-brennen.Aug 5 2020, 6:20 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
Krinkle moved this task from Untriaged to Aug 2020 on the Wikimedia-production-error board.Aug 26 2020, 7:03 PM
DannyS712 removed DannyS712 as the assignee of this task.Aug 28 2020, 9:55 PM
DannyS712 subscribed.

Didn't realize this was assigned to me. Hopefully T246539: Dry-run, then actually run updateVarDumps will resolve this, if I understand T251278#6157584 correctly

daniel mentioned this in T246539: Dry-run, then actually run updateVarDumps.Sep 7 2020, 8:45 AM
gerritbot added a comment.Sep 7 2020, 10:09 AM

Change 625615 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Allow for safe deserialization of WikiPage objects.

https://gerrit.wikimedia.org/r/625615

gerritbot added a project: Patch-For-Review.Sep 7 2020, 10:09 AM
daniel moved this task from Later to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Sep 8 2020, 8:52 AM
gerritbot added a comment.Sep 8 2020, 8:54 AM

Change 625612 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Introduce and apply NonSerializableTrait

https://gerrit.wikimedia.org/r/625612

daniel claimed this task.Sep 9 2020, 3:34 PM
daniel raised the priority of this task from Low to Medium.
• holger.knust removed a project: Patch-For-Review.Sep 17 2020, 6:46 PM
• holger.knust moved this task from Waiting for Review to Later on the Platform Team Workboards (Clinic Duty Team) board.
• holger.knust subscribed.

Moving this to Later and untagging Patch for Review since there is nothing to review right now.

daniel added a comment.Sep 17 2020, 7:37 PM
In T259181#6472043, @holger.knust wrote:

Moving this to Later and untagging Patch for Review since there is nothing to review right now.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/625615 could be reviewed and would fix this error.

gerritbot added a comment.Sep 17 2020, 8:24 PM

Change 625615 merged by jenkins-bot:
[mediawiki/core@master] Allow for safe deserialization of WikiPage objects.

https://gerrit.wikimedia.org/r/625615

daniel moved this task from Later to Done on the Platform Team Workboards (Clinic Duty Team) board.Sep 17 2020, 8:33 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 17 2020, 9:00 PM
gerritbot added a comment.Sep 28 2020, 9:37 PM

Change 625612 merged by jenkins-bot:
[mediawiki/core@master] Introduce and apply NonSerializableTrait

https://gerrit.wikimedia.org/r/625612

ReleaseTaggerBot edited projects, added: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29); removed: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 28 2020, 10:00 PM
DannyS712 added a comment.Dec 8 2020, 5:57 PM

@Daimona is this also resolved, like T259180: Use of Article::prepareContentForEdit was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute] and related, now that updateVarDumps is done running?

Daimona closed this task as Resolved.Dec 8 2020, 5:59 PM

Yeah, I didn't notice this one because it has no subtasks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits