Page MenuHomePhabricator
Create Task
Maniphest T259199

GrowthExperiments Selenium tests break with "Homepage Mentorship module: no mentor available for user ..."
Closed, ResolvedPublic
Actions

Description

Selenium calls the account creation API, HomepageHooks::onLocalUserCreated / onUserSaveOptions is invoked, which tries to set a mentor and logs an error due to no mentors being available, Selenium fails due to error logs being non-empty.

23:21:26 mw-error.log:2020-07-29 21:15:13 c754109020ca wikidb: [7723529a5eb4de2faf1d39d8] /api.php?format=json   MWException from line 114 of /workspace/src/extensions/GrowthExperiments/includes/Mentorship/Mentor.php: Homepage Mentorship module: no mentor available for user NewUser-0.9698587793119762-Iñtërnâtiônàlizætiøn
23:21:26 mw-error.log:#0 /workspace/src/extensions/GrowthExperiments/includes/Mentorship/Mentor.php(45): GrowthExperiments\Mentorship\Mentor::selectMentor(User)
23:21:26 mw-error.log:#1 /workspace/src/extensions/GrowthExperiments/includes/HomepageHooks.php(631): GrowthExperiments\Mentorship\Mentor::newFromMentee(User, boolean)
23:21:26 mw-error.log:#2 /workspace/src/includes/HookContainer/HookContainer.php(154): GrowthExperiments\HomepageHooks->onUserSaveOptions(User, array, array)
23:21:26 mw-error.log:#3 /workspace/src/includes/HookContainer/HookRunner.php(4490): MediaWiki\HookContainer\HookContainer->run(string, array)
23:21:26 mw-error.log:#4 /workspace/src/includes/user/UserOptionsManager.php(394): MediaWiki\HookContainer\HookRunner->onUserSaveOptions(User, array, array)
23:21:26 mw-error.log:#5 /workspace/src/includes/user/User.php(3443): MediaWiki\User\UserOptionsManager->saveOptions(User)
23:21:26 mw-error.log:#6 /workspace/src/includes/auth/AuthManager.php(1447): User->saveSettings()
23:21:26 mw-error.log:#7 /workspace/src/includes/auth/AuthManager.php(1163): MediaWiki\Auth\AuthManager->continueAccountCreation(array)
23:21:26 mw-error.log:#8 /workspace/src/includes/api/ApiAMCreateAccount.php(94): MediaWiki\Auth\AuthManager->beginAccountCreation(User, array, string)
23:21:26 mw-error.log:#9 /workspace/src/includes/api/ApiMain.php(1593): ApiAMCreateAccount->execute()
23:21:26 mw-error.log:#10 /workspace/src/includes/api/ApiMain.php(529): ApiMain->executeAction()
23:21:26 mw-error.log:#11 /workspace/src/includes/api/ApiMain.php(500): ApiMain->executeActionWithErrorHandling()
23:21:26 mw-error.log:#12 /workspace/src/api.php(90): ApiMain->execute()
23:21:26 mw-error.log:#13 /workspace/src/api.php(45): wfApiMain()
23:21:26 mw-error.log:#14 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix selenium test breakage due to error logging with no mentor pagemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.2+2 -2
Introduce MentorManager and virtually assign mentors to all usersmediawiki/extensions/GrowthExperimentsmaster+1 K -569
Fix selenium test breakage due to error logging with no mentor pagemediawiki/extensions/GrowthExperimentsmaster+2 -2
Customize query in gerrit

Event Timeline

Tgr created this task.Jul 29 2020, 9:59 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 29 2020, 9:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jul 29 2020, 10:06 PM

Change 617272 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix selenium test breakage due to error logging with no mentor page

https://gerrit.wikimedia.org/r/617272

gerritbot added a project: Patch-For-Review.Jul 29 2020, 10:06 PM
Tgr added a comment.Jul 29 2020, 10:06 PM

I struggle to identify what caused this - both the hook code and the relevant logic in Mentor have been untouched for many months.

Anyway, c616339 will fix this, as it uses WikiConfigException instead of MWException. If a faster fix is required, c617272 should work.

gerritbot added a comment.Jul 30 2020, 1:29 AM

Change 617272 abandoned by Catrope:
[mediawiki/extensions/GrowthExperiments@master] Fix selenium test breakage due to error logging with no mentor page

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /616339

https://gerrit.wikimedia.org/r/617272

gerritbot added a comment.Jul 30 2020, 1:29 AM

Change 616339 had a related patch set uploaded (by Catrope; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Introduce MentorManager and virtually assign mentors to all users

https://gerrit.wikimedia.org/r/616339

gerritbot added a comment.Jul 30 2020, 1:55 AM

Change 616339 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Introduce MentorManager and virtually assign mentors to all users

https://gerrit.wikimedia.org/r/616339

Tgr closed this task as Resolved.Jul 30 2020, 2:23 PM
Tgr claimed this task.
gerritbot added a comment.Jul 30 2020, 9:03 PM

Change 617438 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.2] Fix selenium test breakage due to error logging with no mentor page

https://gerrit.wikimedia.org/r/617438

gerritbot added a comment.Jul 30 2020, 9:31 PM

Change 617438 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.2] Fix selenium test breakage due to error logging with no mentor page

https://gerrit.wikimedia.org/r/617438

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 30 2020, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits