Adyen message in queue without pending entry
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mepps
	Jul 30 2020, 2:00 PM

Description

Failmail 7/30 4:20am UTC FAILMAIL - ERROR: civi1001 (adyen) SmashPig-Adyen-QueueJobRunner::SPCID
It looks like it had a message it was trying to capture but with no corresponding pending queue message. Might warrant further investigation.

Details

	Subject	Repo	Branch	Lines +/-
	Don't delete Adyen pending info on capture fail	wikimedia/fundraising/SmashPig	master	+5 -21
	Don't delete adyen/astropay pending info on payment fail	wikimedia/fundraising/crm	master	+9 -1

Customize query in gerrit

Related Objects

Mentioned In: T258527: Fr-tech chores list

Event Timeline

• mepps created this task.Jul 30 2020, 2:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2020, 2:00 PM

• mepps mentioned this in T258527: Fr-tech chores list.Jul 30 2020, 3:30 PM

• DStrine added a project: FR-Q2-FY2020-21-cleanup-list.Aug 3 2020, 4:44 PM

• DStrine moved this task from Triage to Sprint +2 on the Fundraising-Backlog board.

Also 80506377.4 failed for the same reason last night.

Since yesterday, I see 7 possible instances of this in the damaged messages.

• DStrine moved this task from Sprint +2 to Sprint +1 on the Fundraising-Backlog board.Nov 2 2020, 9:20 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Nov 10 2020, 8:53 PM

• DStrine added a project: Fundraising Sprint We all meet again.Nov 10 2020, 9:00 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint We all meet again board.Nov 12 2020, 8:30 PM

Change 640845 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Don't delete adyen/astropay pending info on payment fail

https://gerrit.wikimedia.org/r/640845

gerritbot added a project: Patch-For-Review.Nov 12 2020, 8:34 PM

Ejegg moved this task from Doing to Review on the Fundraising Sprint We all meet again board.Nov 12 2020, 8:35 PM

Change 640846 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Don't delete Adyen pending info on capture fail

https://gerrit.wikimedia.org/r/640846

Change 640845 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Don't delete adyen/astropay pending info on payment fail

https://gerrit.wikimedia.org/r/640845

There were two places that we were deleting pending messages for failed auths/captures - the payments-init queue consumer and the IPN listener. Last night I deployed the fix for the payments-init queue consumer, but we're still seeing 'missing donor details' failmail. The fix for the IPN listener needs review here: https://gerrit.wikimedia.org/r/640846

Ejegg claimed this task.Nov 13 2020, 7:25 PM

Ejegg triaged this task as Medium priority.

Change 640846 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Don't delete Adyen pending info on capture fail

https://gerrit.wikimedia.org/r/640846

jgleeson moved this task from Review to Pending Deployment on the Fundraising Sprint We all meet again board.Nov 16 2020, 1:49 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2020, 2:10 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint We all meet again board.Nov 17 2020, 6:44 PM

• DStrine closed this task as Resolved.Nov 24 2020, 8:26 PM