[Bug] Special:MediaSearch UI breaks if no "type" param is present
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	egardner
	Jul 30 2020, 3:59 PM

Description

Just noticed this when looking at the latest version of this page on BetaCommons: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:MediaSearch

If you visit Special:MediaSearch without any URL params, the UI fails to load. This is because the shouldShowEmptyState computed property assumes there is always a "current tab". The initial value of currentTab is based on the URL params the user has when they first land on the page.

Fortunately there is an easy fix here: Vue's created hook runs before computed properties are evaluated. This is a good place to default to a particular current tab / search type; the existing watch property will ensure the URL params get updated as well.

Steps to Reproduce:
Visit: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:MediaSearch without any URL params

Actual Results:
UI fails to display

Expected Results:
UI should appear normally

Details

	Subject	Repo	Branch	Lines +/-
	Initialize UI with default "bitmap" tab if none specified	mediawiki/extensions/WikibaseMediaInfo	master	+16 -0

Customize query in gerrit

Event Timeline

egardner created this task.Jul 30 2020, 3:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2020, 3:59 PM

egardner claimed this task.Jul 30 2020, 4:00 PM

Change 617493 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Initialize UI with default "bitmap" tab if none specified

https://gerrit.wikimedia.org/r/617493

gerritbot added a project: Patch-For-Review.Jul 30 2020, 4:06 PM

egardner moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jul 30 2020, 4:16 PM

Change 617493 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Initialize UI with default "bitmap" tab if none specified

https://gerrit.wikimedia.org/r/617493

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 30 2020, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2020, 9:10 PM

egardner moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jul 30 2020, 9:11 PM

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Aug 5 2020, 12:12 AM