Maniphest T259277

Username suggestion list re-appears after pressing escape
Closed, ResolvedPublic
Actions

Description

Problem

Imagine that you wanted to write the word @pple in your reply - and do not intend for it to be a username;

Open Reply Tool's visual mode
Type @ + pple
Press ⎋
Press space
Type hello

Actual

❗️Notice the username suggestion list reappears and the text you typed in the step above is considered part of the search term you typed in step 2

Expected

✅Notice the text you typed below is entered into the Tool's text input area without the username suggestion

list appearing

Done

The "Expected" behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (510130eaf)	mediawiki/extensions/VisualEditor	master	+1 -1
	Teardown the completion widget when menu is hidden by user	VisualEditor/VisualEditor	master	+13 -1

Customize query in gerrit

Related Objects

Mentioned In: T260443: Mentioning an email address in DiscussionTools makes the system think I'm going to mention someone
T252084: Add header to username suggestion list
Mentioned Here: rGVED510130eaf7f2: Merge "Teardown the completion widget when menu is hidden by user"

Event Timeline

• iamjessklein created this task.Jul 30 2020, 4:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2020, 4:45 PM

• iamjessklein mentioned this in T252084: Add header to username suggestion list.Jul 30 2020, 4:46 PM

• ppelberg edited projects, added DiscussionTools, OWC2020 (Reply Tool Opt Out); removed OWC2020.Jul 31 2020, 7:28 PM

• ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.

• ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.

• ppelberg updated the task description. (Show Details)Aug 1 2020, 1:50 AM

• ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (Reply Tool Opt Out) board.Aug 1 2020, 1:54 AM

Esanders renamed this task from Allow users to add words that start with @ character to a reply to Username suggestion list re-appears after pressing escape.Aug 12 2020, 11:55 AM

Esanders added a subscriber: DLynch.

Change 619736 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Teardown the completion widget when menu is hidden by user

https://gerrit.wikimedia.org/r/619736

gerritbot added a project: Patch-For-Review.Aug 12 2020, 12:17 PM

Esanders claimed this task.Aug 12 2020, 12:17 PM

Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

matmarex mentioned this in T260443: Mentioning an email address in DiscussionTools makes the system think I'm going to mention someone.Aug 16 2020, 6:50 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

Change 619736 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Teardown the completion widget when menu is hidden by user

https://gerrit.wikimedia.org/r/619736

Change 620515 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (510130eaf)

https://gerrit.wikimedia.org/r/620515

Change 620515 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (510130eaf)

https://gerrit.wikimedia.org/r/620515

matmarex edited projects, added Editing QA; removed Patch-For-Review.Aug 16 2020, 7:21 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 16 2020, 8:00 PM

• ppelberg closed this task as Resolved.Oct 1 2020, 11:09 PM

• ppelberg edited projects, added Skipped QA; removed Editing QA.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 1 2020, 11:09 PM

Username suggestion list re-appears after pressing escapeClosed, ResolvedPublicActions