Description

CologneBlue believes its overriding a function on SkinTemplate. It's not. The override does nothing. It should thus be removed.

https://gerrit.wikimedia.org/g/mediawiki/skins/CologneBlue/+/edaaf4d4e3aa45c562b11d69f97c33432bfbe9df/includes/SkinCologneBlue.php#47

(same issue in jeblad / LangCodeOverride)

Details

	Subject	Repo	Branch	Lines +/-
	Remove unused method SkinCologneBlue::formatLanguageName()	mediawiki/skins/CologneBlue	master	+0 -12

Customize query in gerrit

Related Objects

Mentioned Here: rMW484c2f8981ca: SkinTemplate: Remove some tiny private methods

Event Timeline

Jdlrobson created this task.Jul 30 2020, 11:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2020, 11:42 PM

SkinTemplate::formatLanguageName() was removed a while ago in 484c2f8981caf97d2294c8c5e6e49105b17b36d8 (which was even a private method). The overriding in CologneBlue really indeed does nothing.

Will make a patch :)

Change 619116 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/skins/CologneBlue@master] Remove unused method SkinCologneBlue::formatLanguageName()

https://gerrit.wikimedia.org/r/619116

gerritbot added a project: Patch-For-Review.Aug 8 2020, 11:58 AM

Change 619116 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Remove unused method SkinCologneBlue::formatLanguageName()

https://gerrit.wikimedia.org/r/619116