Page MenuHomePhabricator
Create Task
Maniphest T259343

OAuth extension - remove needsWriteAccess function definition from AbstractClientHandler class.
Closed, ResolvedPublic
Actions

Description

The "needsWriteAccess" function definition is to be removed from the AbstractClientHandler class as it's defined in it's parent.

Details

SubjectRepoBranchLines +/-
AbstractClientHandler: OAuth extension - remove needsWriteAccess function definition from AbstractClientHandler classmediawiki/extensions/OAuthmaster+0 -7
Customize query in gerrit

Event Timeline

Art.tsymbar created this task.Jul 31 2020, 12:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2020, 12:07 PM
Helga_sf added a project: Platform Team Workboards (S&F Workboard).Jul 31 2020, 12:09 PM
Reedy added a project: MediaWiki-extensions-OAuth.Jul 31 2020, 1:13 PM
Reedy removed subscribers: Platform Team Workboards, MediaWiki-extensions-OAuth.
Helga_sf triaged this task as Low priority.Aug 27 2020, 12:17 PM
Art.tsymbar moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Sep 8 2020, 10:37 AM
Vlad.shapik moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Sep 26 2020, 8:26 AM
Vlad.shapik claimed this task.Sep 26 2020, 8:28 AM
gerritbot added a comment.Sep 27 2020, 8:39 AM

Change 630361 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/OAuth@master] AbstractClientHandler: OAuth extension - remove needsWriteAccess function definition from AbstractClientHandler class

https://gerrit.wikimedia.org/r/630361

gerritbot added a project: Patch-For-Review.Sep 27 2020, 8:39 AM
Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Sep 27 2020, 8:46 AM
gerritbot added a comment.Sep 27 2020, 2:57 PM

Change 630361 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] AbstractClientHandler: OAuth extension - remove needsWriteAccess function definition from AbstractClientHandler class

https://gerrit.wikimedia.org/r/630361

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 27 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 27 2020, 3:10 PM
Art.tsymbar moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Sep 28 2020, 9:33 AM
Reedy closed this task as Resolved.Oct 25 2020, 8:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL