Page MenuHomePhabricator
Create Task
Maniphest T259390

[S] (minor) MediaSearch UI issues
Closed, ResolvedPublic
Actions

Assigned To
AnneT
Authored By
Etonkovidova
Jul 31 2020, 8:30 PM
Tags
Referenced Files
F31956014: next_appears2.gif
Jul 31 2020, 8:30 PM
F31956034: Screen Shot 2020-07-31 at 1.03.08 PM.png
Jul 31 2020, 8:30 PM
F31956020: Screen Shot 2020-07-29 at 5.00.11 PM.png
Jul 31 2020, 8:30 PM
F31956036: Screen Shot 2020-07-31 at 1.03.25 PM.png
Jul 31 2020, 8:30 PM
F31956022: Screen Shot 2020-07-29 at 5.00.34 PM.png
Jul 31 2020, 8:30 PM
Subscribers
Aklapper
CBogen
egardner
Etonkovidova
mwilliams
• Ramsey-WMF

Description

Fixed (see the comment) (1) Some text/controls are displayed briefly when Special:MediaSearch page loads.
(click to see animated gif)

next_appears2.gif (692×1 px, 105 KB)

(2) Parts of long search query strings are displayed under the icon "mw-icon mw-indicator-component__icon oo-ui-image-invert oo-ui-icon-close"

Special:MediaSearchSpecial:Search
Screen Shot 2020-07-29 at 5.00.11 PM.png (198×824 px, 21 KB)
Screen Shot 2020-07-29 at 5.00.34 PM.png (279×838 px, 29 KB)

Fixed (3) Mobile - the font-size for "wbmi-media-search-input__input" is 14px which looks small (Special:Search "oo-ui-inputWidget-input" has font-size: 100%; which is a browser default 16px).
Note: the Desktop search box text font-size is the same for both pages - Special:MediaSearch (14px) and Special:Search (font-size: calc(1em * 0.875).

Special:MediaSearchSpecial:Search
Screen Shot 2020-07-31 at 1.03.08 PM.png (667×379 px, 46 KB)
Screen Shot 2020-07-31 at 1.03.25 PM.png (670×381 px, 66 KB)

Details

SubjectRepoBranchLines +/-
Account for indicator in search input paddingmediawiki/extensions/WikibaseMediaInfomaster+5 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jul 31 2020, 8:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2020, 8:30 PM
• Ramsey-WMF edited projects, added Structured-Data-Backlog (Current Work), MediaSearch (MediaSearch-Beta); removed StructuredDataOnCommons.Jul 31 2020, 8:44 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Aug 4 2020, 3:30 PM
CBogen renamed this task from (minor) MediaSearch UI issues to [S] (minor) MediaSearch UI issues.Aug 5 2020, 4:27 PM
CBogen edited projects, added MediaSearch (MediaSearch-Alpha); removed MediaSearch (MediaSearch-Beta).
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Aug 5 2020, 4:29 PM
mwilliams subscribed.Aug 11 2020, 7:47 PM
egardner edited projects, added MediaSearch (MediaSearch-Beta); removed MediaSearch (MediaSearch-Alpha).Aug 13 2020, 4:14 PM
egardner subscribed.

I'm bumping this to beta for now (we can tackle it sooner if we get the rest of the alpha tasks done).

In general I'd say at this point all design improvements and mobile improvements can be handled in the Beta milestone; Alpha should be for getting the key functionality correct and (mostly) complete.

AnneT claimed this task.Aug 13 2020, 4:28 PM
• Ramsey-WMF edited projects, added MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog; removed MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work).Sep 9 2020, 8:26 PM

Bumping this one to later (cleanup/polish for RC) since Beta phase is pretty packed right now.

• Ramsey-WMF moved this task from Triage to Section Topics on the Structured-Data-Backlog board.Sep 9 2020, 8:26 PM
Etonkovidova added a comment.Sep 21 2020, 11:16 PM

(1) Some text/controls are displayed briefly when Special:MediaSearch page loads.
(click to see animated gif)

next_appears2.gif (692×1 px, 105 KB)

The issue was fixed with T258611 patch - https://gerrit.wikimedia.org/r/623358

Etonkovidova updated the task description. (Show Details)Sep 21 2020, 11:16 PM
Etonkovidova mentioned this in T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end.Sep 21 2020, 11:34 PM
AnneT edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 9 2020, 7:19 PM
AnneT moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Oct 9 2020, 7:32 PM

Change 633235 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Account for indicator in search input padding

https://gerrit.wikimedia.org/r/633235

gerritbot added a project: Patch-For-Review.Oct 9 2020, 7:32 PM
AnneT updated the task description. (Show Details)Oct 9 2020, 7:32 PM
AnneT moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 29 2020, 6:47 PM
gerritbot added a comment.Oct 29 2020, 6:52 PM

Change 633235 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Account for indicator in search input padding

https://gerrit.wikimedia.org/r/633235

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 29 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 7:11 PM
Etonkovidova closed this task as Resolved.Nov 24 2020, 3:25 AM

Checked in commons wmf.18

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits