Page MenuHomePhabricator

[S] (minor) MediaSearch UI issues
Closed, ResolvedPublic

Description

Fixed (see the comment) (1) Some text/controls are displayed briefly when Special:MediaSearch page loads.
(click to see animated gif)

next_appears2.gif (692×1 px, 105 KB)

(2) Parts of long search query strings are displayed under the icon "mw-icon mw-indicator-component__icon oo-ui-image-invert oo-ui-icon-close"

Special:MediaSearchSpecial:Search
Screen Shot 2020-07-29 at 5.00.11 PM.png (198×824 px, 21 KB)
Screen Shot 2020-07-29 at 5.00.34 PM.png (279×838 px, 29 KB)

Fixed (3) Mobile - the font-size for "wbmi-media-search-input__input" is 14px which looks small (Special:Search "oo-ui-inputWidget-input" has font-size: 100%; which is a browser default 16px).
Note: the Desktop search box text font-size is the same for both pages - Special:MediaSearch (14px) and Special:Search (font-size: calc(1em * 0.875).

Special:MediaSearchSpecial:Search
Screen Shot 2020-07-31 at 1.03.08 PM.png (667×379 px, 46 KB)
Screen Shot 2020-07-31 at 1.03.25 PM.png (670×381 px, 66 KB)

Event Timeline

CBogen renamed this task from (minor) MediaSearch UI issues to [S] (minor) MediaSearch UI issues.Aug 5 2020, 4:27 PM
egardner added a subscriber: egardner.

I'm bumping this to beta for now (we can tackle it sooner if we get the rest of the alpha tasks done).

In general I'd say at this point all design improvements and mobile improvements can be handled in the Beta milestone; Alpha should be for getting the key functionality correct and (mostly) complete.

(1) Some text/controls are displayed briefly when Special:MediaSearch page loads.
(click to see animated gif)

next_appears2.gif (692×1 px, 105 KB)

The issue was fixed with T258611 patch - https://gerrit.wikimedia.org/r/623358

Change 633235 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Account for indicator in search input padding

https://gerrit.wikimedia.org/r/633235

Change 633235 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Account for indicator in search input padding

https://gerrit.wikimedia.org/r/633235

Checked in commons wmf.18