Page MenuHomePhabricator
Create Task
Maniphest T259393

Changing the uselang (user language) in Special:Investigate cases a 404 (not found)
Closed, ResolvedPublic
Actions

Description

Problem

In T253823#6224695, @dom_walden wrote:

Oh, another thing I noticed: while on one of the tabs, if I change the interface language (e.g. via uselang URL param or Special:Preferences) and refresh I am taken to a blank page (no data, just the 3 tabs). This appears to be because the URL is still in whatever my language was before I changed it, but now it expects it to be in the language I just changed to.

I don't know if this will be a problem in reality. Do CheckUser need to change their interface languages mid-investigation for any reason?

enqueter.png (382×1 px, 34 KB)

Proposed Solution
SpecialPageFactory::getLocalNameFor() always uses the content language to determine the "local" name, the same should be done for the URLs in for the subpages in Special:Investigate

Details

SubjectRepoBranchLines +/-
Use the content language for the Special:Investigate tab urls.mediawiki/extensions/CheckUsermaster+18 -6
Customize query in gerrit

Related Objects

Event Timeline

dbarratt created this task.Jul 31 2020, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2020, 9:29 PM
dbarratt updated the task description. (Show Details)Jul 31 2020, 9:30 PM
dbarratt added a subscriber: dom_walden.
Reedy renamed this task from Changing the uselang (user language) in Special:Investigate cases a 404 (not found) to Changing the uselang (user language) in Special:Investigate causes a 404 (not found).Jul 31 2020, 9:34 PM
dbarratt renamed this task from Changing the uselang (user language) in Special:Investigate causes a 404 (not found) to Changing the uselang (user language) in Special:Investigate cases a 404 (not found).Jul 31 2020, 9:35 PM
dbarratt updated the task description. (Show Details)
gerritbot added a comment.Jul 31 2020, 9:37 PM

Change 617773 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Use the content language for the Special:Investigate tab urls.

https://gerrit.wikimedia.org/r/617773

gerritbot added a project: Patch-For-Review.Jul 31 2020, 9:37 PM
dbarratt added projects: CheckUser, Anti-Harassment.Jul 31 2020, 9:37 PM
• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Jul 31 2020, 9:40 PM
• Niharika moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Tchanders assigned this task to dbarratt.Aug 3 2020, 12:18 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Aug 3 2020, 12:51 PM
gerritbot added a comment.Aug 3 2020, 1:36 PM

Change 617773 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Use the content language for the Special:Investigate tab urls.

https://gerrit.wikimedia.org/r/617773

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 3 2020, 2:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q1 (2020-21) 💯 on the Anti-Harassment (The Letter Song) board.Aug 11 2020, 1:48 PM

On all three tabs, I experimented changing the language (through uselang in the URL and Special:Preferences) and refreshing the page.

The correct page was always displayed.

The URL always stays in English.

Test environment: https://test.wikipedia.org MediaWiki 1.36.0-wmf.3 (rMW08bcb82e3cfc) 18:13, 6 August 2020; CheckUser 2.5 (aeb6ef5) 21:28, 3 August 2020

• Niharika closed this task as Resolved.Aug 14 2020, 9:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL