Modern should use standardized IDs in footer
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 31 2020, 11:45 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Ammarpad

Jdlrobson

Description

Modern uses IDs in the footer that don't match with other skins. Let's settle on standard IDs.

#mw_copyright => #footer-copyrightico
#mw_poweredby => #footer-poweredbyico
#footer-info-privacy => r => #footer-places-privacy
#footer-info-about => #footer-places-about
#footer-info-disclaimer => #footer-places-disclaimer
#footer-info-contact => #footer-places-contact
#footer-info-mobileview => footer-places-mobileview

Given the low usage of Modern it should be fine to do this right away. Please tag User-notice once code is merged.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Make Modern modern again (at least from a technology standpoint)	Jdlrobson	mediawiki/skins/Modern	master	+151 -395

Customize query in gerrit

Related Objects

Mentioned In: T262730: SkinMustache should provide raw data for rendering a footer
T262098: SkinMustache should provide standard portlet (menu) data

Event Timeline

Jdlrobson created this task.Jul 31 2020, 11:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2020, 11:45 PM

Jdlrobson triaged this task as Medium priority.Aug 4 2020, 8:42 PM

Jdlrobson added a project: patch-welcome.

Jdlrobson mentioned this in T262098: SkinMustache should provide standard portlet (menu) data.Sep 4 2020, 9:22 PM

Jdlrobson mentioned this in T262730: SkinMustache should provide raw data for rendering a footer.Sep 12 2020, 1:51 AM

Change 585834 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Modern@master] Make Modern modern again (at least from a technology standpoint)

https://gerrit.wikimedia.org/r/585834

gerritbot added a project: Patch-For-Review.Oct 1 2020, 12:49 AM

Change 585834 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Make Modern modern again (at least from a technology standpoint)

https://gerrit.wikimedia.org/r/585834

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2020, 9:11 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 8 2020, 10:00 AM

Only 3 end users should be impacted by this change and I've patched them all so we can skip the user notice here:

https://global-search.toolforge.org/?q=%28mw_copyright%7Cmw_poweredby%7Cfooter-info-privacy%7Cfooter-info-about%7Cfooter-info-disclaimer%7Cfooter-info-contact%7Cfooter-info-mobileview%29&regex=1&namespaces=&title=.*%28modern%7Ccommon%29%5C.css

Thanks @Ammarpad for the review and making our skins much easier to manage.

Modern should use standardized IDs in footerClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Modern should use standardized IDs in footer
Closed, ResolvedPublic
Actions