Diff.php which doesn't pass PHP lint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Aug 1 2020, 4:59 AM

Description

PHP Parse error:  syntax error, unexpected '=' in /usr/share/mediawiki/vendor/wikimedia/parsoid/src/Utils/Diff.php on line 20
Errors parsing /usr/share/mediawiki/vendor/wikimedia/parsoid/src/Utils/Diff.php

My guess is that this file was never ported? Can it be deleted? It triggered/failed my Debian PHP lint checks.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Bump Parsoid to v0.12.0-a23	mediawiki/vendor	REL1_35	+13 -376

Customize query in gerrit

Related Objects

Mentioned In: T259452: Release parsoid 0.12.0 and bump it in REL1_35
T259449: upgrade 1.34.2 to 1.35.0-rc.0 fails
Mentioned Here: T259452: Release parsoid 0.12.0 and bump it in REL1_35

Event Timeline

Legoktm created this task.Aug 1 2020, 4:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2020, 4:59 AM

Change 617808 had a related patch set uploaded (by Legoktm; owner: C. Scott Ananian):
[mediawiki/vendor@REL1_35] Bump Parsoid to v0.12.0-a23

https://gerrit.wikimedia.org/r/617808

gerritbot added a project: Patch-For-Review.Aug 1 2020, 5:26 AM

Looks like this was fixed in master but missed a REL1_35 backport.

Also this causes update.php to fail because core's composer.json wants a23 but vendor still has a22.

Somewhat related: for the next 1.35 RC I'd like to bump parsoid from 0.12.0-a23 to 0.12.0 and make it a proper 'non-alpha' release. We didn't quite manage that before the branch.

Change 617808 merged by Reedy:
[mediawiki/vendor@REL1_35] Bump Parsoid to v0.12.0-a23

https://gerrit.wikimedia.org/r/617808

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2020, 2:10 PM

ssastry moved this task from Needs Triage to Current & Upcoming Work on the Parsoid board.Aug 2 2020, 5:43 PM

RazeSoldier mentioned this in T259449: upgrade 1.34.2 to 1.35.0-rc.0 fails.Aug 3 2020, 7:25 AM

In T259402#6353647, @cscott wrote:

Somewhat related: for the next 1.35 RC I'd like to bump parsoid from 0.12.0-a23 to 0.12.0 and make it a proper 'non-alpha' release. We didn't quite manage that before the branch.

Ack, filed as T259452: Release parsoid 0.12.0 and bump it in REL1_35.

Legoktm renamed this task from vendor/wikimedia/parsoid/src/Utils/Diff.php doesn't pass PHP lint to parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint.Aug 3 2020, 7:31 AM

Legoktm merged a task: T259449: upgrade 1.34.2 to 1.35.0-rc.0 fails.

Legoktm added subscribers: joernc_unibi, RazeSoldier.

parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lintClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint
Closed, ResolvedPublic
Actions