Page MenuHomePhabricator
Create Task
Maniphest T259445

Unnecessary quotes in ref names in <references>...<references> sectiion
Open, MediumPublic
Actions

Description

I use the source editor, and often put references between <references>...</references> to keep he source uncluttered.

It seems that the visual editor will insert unnecessary quotes around the names of ALL such references, whenever it is used to edit the article. See for example [https://en.wikipedia.org/w/index.php?title=Graphene&type=revision&diff=970831602&oldid=970749638 This change] (search for <references>)

As that example shows, that insertion of unnecessary quotes confuses the "diff" algorithm and creates huge and confusing change logs. Could you please fix the visual editor so that it preserves any entries between <references> and </references> unchanged?

Related Objects
Search...

Event Timeline

Jorge_Stolfi created this task.Aug 2 2020, 9:05 PM
Restricted Application added projects: Community-Tech, VisualEditor-MediaWiki-References. · View Herald TranscriptAug 2 2020, 9:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ldelench_wmf removed a project: Community-Tech.Jul 28 2021, 2:05 PM
matmarex added a project: Parsoid.Jul 28 2021, 2:06 PM
MusikAnimal removed a project: VisualEditor-Named-References.Jul 28 2021, 3:16 PM
• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jul 29 2021, 3:05 PM
Arlolra subscribed.Jul 29 2021, 9:02 PM

A simple way to reproduce this is by editing the contents of the "a" ref,

<ref name="a" />

<references>
<ref name=b>test</ref>
<ref name="a">haha</ref>
</references>

The granularity of diff'ing will say that references tag was modified and then the whole thing will be normalized. This is another case for T214651

Arlolra triaged this task as Medium priority.Jul 29 2021, 9:02 PM
Arlolra moved this task from Needs Triage to Feature requests on the Parsoid board.
Arlolra added a parent task: T214651: The extension api seems to want a dom-diff-handler.
• Whatamidoing-WMF subscribed.Aug 16 2022, 7:17 PM

The inclusion of the "unnecessary" quotation marks in ref names is correct. The fact that the system doesn't visibly break when they're absent does not mean that it's correct for them to be absent.

It sounds like what we really need in this instance is a smarter diff tool.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL