Page MenuHomePhabricator
Create Task
Maniphest T259468

Version compare apps' externalized modules and core modules
Closed, ResolvedPublic
Actions

Description

tldr; We use vue and vuex from core. THis can cause surprises if core changes the version and Wikibase product don't realize. We could do with some check or test for this.

There is no guarantee that Package.jsons of our applications and MediaWiki core, holding externalized versions of those packages (vue, vuex), actually align.
We should add some form of testing to ensure nothing breaks in the future.

https://gerrit.wikimedia.org/r/591328 made a first suggestion for that

Acceptance Criteria:

  • There is an automated way of ensuring that versions of vue and vuex packages defined in package.json file of the (micro)application and delivered by the master branch of MediaWiki in resources/lib/vue/vue.common.prod.unminified.js are aligned
    • Wikibase
    • Data Bridge (client/data-bridge/package.json)
    • Tainted References (view/lib/wikibase-tainted-ref/package.json)
    • Termbox v2
    • WikibaseLexeme

Details

SubjectRepoBranchLines +/-
WikibaseLexeme: add test comparing Vue versions with MWmediawiki/extensions/WikibaseLexememaster+42 -0
Termbox: add test comparing Vue versions with MWwikibase/termboxmaster+33 -0
Tainted-ref: add test comparing Vue versions with MWmediawiki/extensions/Wikibasemaster+35 -4
Wikibase: add test comparing Vue versions with MWmediawiki/extensions/Wikibasemaster+35 -0
bridge: add test comparing Vue versions with MWmediawiki/extensions/Wikibasemaster+308 -241
bridge: test appropriate MediaWiki branch in mwlibsmediawiki/extensions/Wikibasemaster+5 -2
Customize query in gerrit

Related Objects

Event Timeline

• Pablo-WMDE created this task.Aug 3 2020, 9:10 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 3 2020, 9:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Michael mentioned this in T247520: Use "vue" ResourceLoader module from core.Aug 3 2020, 11:27 AM
darthmon_wmde added a project: Wikidata-Campsite.Aug 4 2020, 12:16 PM
darthmon_wmde moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Oct 13 2020, 10:50 AM
WMDE-leszek updated the task description. (Show Details)Oct 28 2020, 8:23 AM
• Pablo-WMDE added a project: User-Pablo-WMDE.Nov 19 2020, 8:23 AM
• Pablo-WMDE moved this task from Incoming to Short term on the User-Pablo-WMDE board.
WMDE-leszek subscribed.Nov 26 2020, 11:39 AM

It has been spaculated that potential approach could be putting a version number used to mediawiki's package.json, and having a machinery in place in mediawiki that ensure that that information stays accurate

Jakob_WMDE updated the task description. (Show Details)Nov 26 2020, 1:35 PM
Jakob_WMDE subscribed.

From the task inspection: We go with an approach similar to the one outlined in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/591328/ but instead of checking the version number from a file loaded via the file system (which doesn't work because it's not available) we need to download the relevant Vue and Vuex module files from MediaWiki core and check against those.

Jakob_WMDE moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Nov 26 2020, 1:37 PM
Jakob_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 26 2020, 2:16 PM
noarave claimed this task.Nov 27 2020, 9:15 AM
Restricted Application added a project: User-Noarave. · View Herald TranscriptNov 27 2020, 9:15 AM
noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 27 2020, 9:15 AM
gerritbot added a comment.Dec 3 2020, 8:15 AM

Change 645029 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] bridge: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/645029

gerritbot added a project: Patch-For-Review.Dec 3 2020, 8:15 AM
noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 3 2020, 8:23 AM
noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 3 2020, 12:52 PM
noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 3 2020, 1:13 PM
gerritbot added a comment.Dec 3 2020, 3:23 PM

Change 645098 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: test appropriate MediaWiki branch in mwlibs

https://gerrit.wikimedia.org/r/645098

gerritbot added a comment.Dec 3 2020, 3:47 PM

Change 645029 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/645029

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 3 2020, 4:01 PM
noarave updated the task description. (Show Details)Dec 7 2020, 1:00 PM
noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Dec 7 2020, 1:23 PM

Change 645098 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: test appropriate MediaWiki branch in mwlibs

https://gerrit.wikimedia.org/r/645098

Maintenance_bot removed a project: Patch-For-Review.Dec 7 2020, 2:10 PM
gerritbot added a comment.Dec 7 2020, 2:21 PM

Change 646681 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Wikibase: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/646681

gerritbot added a project: Patch-For-Review.Dec 7 2020, 2:21 PM
noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 7 2020, 2:22 PM
noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 14 2020, 9:54 AM
noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 14 2020, 12:29 PM
gerritbot added a comment.Dec 14 2020, 1:45 PM

Change 646681 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wikibase: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/646681

noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 14 2020, 1:46 PM
noarave updated the task description. (Show Details)
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.22; 2020-12-15); removed MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 14 2020, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 2:10 PM
gerritbot added a comment.Dec 15 2020, 1:56 PM

Change 649644 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Tainted-ref: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/649644

gerritbot added a project: Patch-For-Review.Dec 15 2020, 1:56 PM
noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 15 2020, 2:29 PM
noarave updated the task description. (Show Details)Dec 16 2020, 12:23 PM
noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 16 2020, 12:27 PM
noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 16 2020, 1:40 PM
gerritbot added a comment.Dec 17 2020, 11:18 AM

Change 649644 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Tainted-ref: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/649644

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 17 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 17 2020, 12:10 PM
noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 17 2020, 12:52 PM
gerritbot added a comment.Dec 17 2020, 1:28 PM

Change 650115 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/WikibaseLexeme@master] WikibaseLexeme: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/650115

gerritbot added a project: Patch-For-Review.Dec 17 2020, 1:28 PM
gerritbot added a comment.Dec 17 2020, 2:19 PM

Change 650124 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[wikibase/termbox@master] Termbox: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/650124

gerritbot added a comment.Dec 17 2020, 3:33 PM

Change 650124 merged by jenkins-bot:
[wikibase/termbox@master] Termbox: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/650124

noarave mentioned this in rWBTB94eb4341fbd5: Termbox: add test comparing Vue versions with MW.Dec 17 2020, 5:43 PM
noarave updated the task description. (Show Details)Dec 18 2020, 8:47 AM
gerritbot added a comment.Dec 18 2020, 9:36 AM

Change 650115 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] WikibaseLexeme: add test comparing Vue versions with MW

https://gerrit.wikimedia.org/r/650115

noarave moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 18 2020, 9:39 AM
noarave updated the task description. (Show Details)
WMDE-leszek closed this task as Resolved.Jan 6 2021, 12:43 PM
WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
WMDE-leszek mentioned this in T271413: Separate implementation from configuration in Wikibase's Vue version comparison test.Jan 7 2021, 11:49 AM

Created a follow up ticket for a possible improvement, that has been pondered during the code review: T271413.

Lucas_Werkmeister_WMDE mentioned this in T273881: Unify external library configuration for Wikibase projects.Feb 4 2021, 1:48 PM
Tarrow mentioned this in T250266: Termbox: Use "vuex" ResourceLoader module from core.Apr 6 2021, 10:30 AM
wiese moved this task from Short term to Done on the User-Pablo-WMDE board.Mar 18 2022, 2:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL