Page MenuHomePhabricator

Escape bot password correctly
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. python generate_user_files.py
  2. At the password part for your bot enter a password that includes an ' (Apostrophe). (Example secret'password)

Actual Results:

user-password.py will not work as the following code will be generated

('BOT_NAME', BotPassword('BOT_NAME', 'secret'password'))

Expected Results:

('BOT_NAME', BotPassword('BOT_NAME', "secret'password"))

Event Timeline

Xqt triaged this task as Medium priority.

Change 618108 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Escape bot password correctly

https://gerrit.wikimedia.org/r/618108

Xqt renamed this task from Escape user-password correctly to Escape bot password correctly.Aug 3 2020, 5:45 PM
Xqt updated the task description. (Show Details)

Change 618108 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Escape bot password correctly

https://gerrit.wikimedia.org/r/618108