Page MenuHomePhabricator

Pick a sentence: Show section contents
Closed, ResolvedPublic

Description

As part of the "Pick a sentence" step (T251551) of the Section Translation mobile editor, the contents of the section will be loaded and shown in a way that users can navigate on a sentence-by-sentence basis.

Pick a sentence - Contents.png (768×1 px, 186 KB)
Pick a sentence - Contents Dimensions.png (768×1 px, 126 KB)

Further context

Pick a sentence - Overview.png (768×1 px, 111 KB)

Event Timeline

Pginer-WMF triaged this task as Medium priority.Aug 3 2020, 10:54 AM
Pginer-WMF raised the priority of this task from Medium to High.
Pginer-WMF created this task.

I've noticed some mismatches with the specification:

  • The spacing between the article title and the section title is 4px in the specification. Inspecting the implementation seems to be 8px instead.
  • The "open in new tab" icon should be smaller to fit with the article title size. the spec indicates a 10x10px icon, but in a similar situation I think we used a 12x12px instead. So we can standardize around that for smaller icons.
Implementation
Screenshot 2020-09-18 at 12.29.08.png (671×1 px, 32 KB)
Spec
Pick a sentence - Contents Dimensions.png (143×462 px, 12 KB)
Pginer-WMF lowered the priority of this task from High to Low.Sep 18 2020, 10:38 AM

Change 628886 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Create content header SFC and fix UI glitches

https://gerrit.wikimedia.org/r/628886

Change 628886 merged by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Create content header SFC and fix UI glitches

https://gerrit.wikimedia.org/r/628886