GrowthExperiments homepage mentor dialog breaks when help panel is disabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Aug 3 2020, 11:10 AM

Description

Steps to reproduce:

Enable "Display newcomer homepage" and disable "Enable the editor help panel" in preferences
Go to Special:Homepage
Click "Ask your mentor a question"

Results in fallback behavior (the mentor's talk page is opened for editing) with

VM218 load.php:2 TypeError: Cannot read property 'name' of null
    at helpPanelProcessDialog.HelpPanelProcessDialog.configureAskScreen (VM224 load.php:15)
    at new helpPanelProcessDialog (VM224 load.php:12)
    at attachButton (VM224 load.php:59)
    at VM224 load.php:57
    at homepage/ext.growthExperiments.Homepage.Mentorship.js (VM224 load.php:57)
    at runScript (VM218 load.php:13)
    at execute (VM218 load.php:14)
    at doPropagation (VM218 load.php:7)

Rproducible in beta but not in production.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix homepage mentorship module	mediawiki/extensions/GrowthExperiments	master	+9 -3

Customize query in gerrit

Related Objects

Mentioned In: T255425: Refactor help panel code
Mentioned Here: rEGRE7bbdc4714229: Fix help panel ask screen wording

Event Timeline

Tgr created this task.Aug 3 2020, 11:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2020, 11:10 AM

Broken by rEGRE7bbdc4714229: Fix help panel ask screen wording which unified configuration logic for homepage and help panel mentor questions, and always used the variable provided by HelpPanelHooks (which does work on the homepage, but only if the help panel is enabled).

Tgr mentioned this in T255425: Refactor help panel code.Aug 3 2020, 12:02 PM

Change 618053 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix homepage mentorship module

https://gerrit.wikimedia.org/r/618053

gerritbot added a project: Patch-For-Review.Aug 3 2020, 12:26 PM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 3 2020, 12:27 PM

Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 3 2020, 11:23 PM

Change 618053 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix homepage mentorship module

https://gerrit.wikimedia.org/r/618053

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 4 2020, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2020, 12:10 AM

Etonkovidova closed this task as Resolved.Aug 4 2020, 8:56 PM