Page MenuHomePhabricator

Pick a sentence: Card to display and apply MT
Closed, ResolvedPublic

Description

As part of the "Pick a sentence" step (T251551) of the Section Translation mobile editor, a card is shown at the bottom of the viewport with the proposed Machine Translation.

Pick a sentence - Proposal.png (768×1 px, 252 KB)
Pick a sentence - Proposal Dimensions.png (768×1 px, 56 KB)

Messages:

Edit translation
Apply
Skip

More details in the parent task: T251551: Section Translation Editor: Pick a sentence

Event Timeline

Change 626636 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Implement translation action buttons

https://gerrit.wikimedia.org/r/626636

Change 626636 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Implement translation action buttons

https://gerrit.wikimedia.org/r/626636

Jpita added a subscriber: Jpita.

I can't reach this screen on mobile devices because I can't skip the tutorial screens T262665.
On chrome devtools the "edit translation" button shows black instead of blue as is defined in the designs

image.png (265×643 px, 14 KB)

@Pginer-WMF do we fix this (the color) on this task or create another one?

@Pginer-WMF do we fix this (the color) on this task or create another one?

Seems a quick fix. So I'd recommend fixing in the current one.

@Pginer-WMF do we fix this (the color) on this task or create another one?

Seems a quick fix. So I'd recommend fixing in the current one.

Moving to in progress then

Change 628907 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Fix edit translation button color

https://gerrit.wikimedia.org/r/628907

Change 628907 merged by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Fix edit translation button color

https://gerrit.wikimedia.org/r/628907

  • edit translation button is not blue
    image.png (74×262 px, 3 KB)
  • previous action doesn't select the previous sentence, just unselects the sentence

unselect.gif (616×296 px, 1 MB)

is this to be fixed on this task or a different one?

Pginer-WMF lowered the priority of this task from High to Medium.Sep 28 2020, 9:48 AM

is this to be fixed on this task or a different one?

I think it makes sense to fix in the current ticket.
I'll move the ticket back to the priority backlog but with lower priority to avoid interfering with other work of a higher priority.

I think that all issues on this ticket have been resolved. Please take a look at the screencast: https://imgur.com/a/IMksGBV