| Pginer-WMF | |
| Aug 3 2020, 1:04 PM |
| F33934861: image.png | |
| Dec 3 2020, 9:59 PM |
| F32446196: image.png | |
| Nov 6 2020, 1:49 PM |
| F32364332: image.png | |
| Sep 28 2020, 10:28 AM |
| F31803670: Edit a sentence - Editor.png | |
| Aug 3 2020, 1:04 PM |
As part of the "Edit a sentence" step (T251928) of the Section Translation mobile editor, users will be able to modify the translation with Mobile Visual Editor and persist the changes when taping "next".
A separate task will support providing feedback for the user about the saving process (T259511).
More details in the parent task: T251928: Section Translation Editor: Edit a sentence
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T243495 [Epic] Support for Section Translation | |||
| Open | None | T251928 Section Translation Editor: Edit a sentence | |||
| Resolved | ngkountas | T259510 Edit a sentence: Support saving changes |
Change 627944 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXEditor: Set edited translation state variable on edit completed
Change 627944 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXEditor: Set edited translation state variable on edit completed
there's a white space after the "next" button that is not in the designs.
Fixed here or different task @Pginer-WMF ?
Good catch. Mobile VE seems to adjust the toolbar to the viewport width, but our integration does not.
I'm inclined to create a separate task since getting into the VE internals may come with unexpected complications. I created the following one: T264015: The editing toolbar should adjust better to the screen width
I've reused your image, but feel free to add more details if needed.
saving process adds blank paragraphs.
(had to upload to google drive because the file was too big for phab)
https://drive.google.com/file/d/1vxGBTYlKPOK9STVbAO4e2AajPT6dSinS/view?usp=sharing
is this something to:
Good catch. @ngkountas, is this something that requires changes on VE or can be solved on our side? If it requires a more complex fix we can create a separate task.
There is also another aspect that we may want to adjust: taping "next" should add the changes to the translation directly.
I think the empty paragraphs may be caused by a Visua l Editor mechanism where paragraph placeholders (they call them "slugs") are shown for users to click and add content. This is a related ticket about how this was dealt with in Content Translation in case it is useful: T209479: "Insert paragraph" slug receives input focus
Change 640677 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Editor: Change editing result handling
Change 640677 merged by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SX Editor: Apply translation on VE next button click
found a different issue:
1-start a translation of the vlasovite article
2-select the section "structure"
3-edit the translation of the title
4-delete the whole word and save the translation
5-click "Done"
6-click the confirm button
we get this error
@ngkountas is this going to be fixed here or should I create a new ticket?
I think a separate ticket would be better as it doesn't seem to me like it falls in the same scope as this ticket. Apart from that, and given that current behaviour is not the desired one, I'm not sure which is the expected behaviour for this edge case. @Pginer-WMF could you clarify what should happen when user translates the section title but leave it blank after edit? Should we fallback to the original title? Should we block the user from going to the next step until they fix the section title?
