Page MenuHomePhabricator

Preview and publish: Preview contents for users to confirm
Closed, ResolvedPublic

Description

As part of the "Preview and publish" step (T252542) of the mobile editor for Section Translation, users can preview the contents to be published.

This ticket captures the basic functionality for viewing the contents (other tickets will add further options to publish and more).

Publish - Overview.png (768×1 px, 93 KB)
Publish - Preview.png (768×1 px, 133 KB)

More details in the parent task: T252542: Section Translation Editor: Preview and publish

Event Timeline

Pginer-WMF renamed this task from Preview and publish: to Preview and publish: Preview contents for users to confirm.Aug 3 2020, 1:38 PM
Pginer-WMF triaged this task as Medium priority.
Pginer-WMF created this task.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF raised the priority of this task from Medium to High.Aug 4 2020, 7:47 AM

Change 630892 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Preview and publish: Create first version of component

https://gerrit.wikimedia.org/r/630892

Change 630892 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Preview and publish: Create first version of component

https://gerrit.wikimedia.org/r/630892

Jpita added a subscriber: Jpita.

at this moment, the untraslated text is still showing for publishing, will this be fixed later ?

image.png (1×888 px, 229 KB)

image.png (394×1 px, 174 KB)

Change 639457 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX PageSection model: Fix translationHtml to return only translated

https://gerrit.wikimedia.org/r/639457

Change 639457 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX PageSection model: Fix translationHtml to return only translated

https://gerrit.wikimedia.org/r/639457

If I don't translate anything and click the "Done" button, then it shows the title of the section not translated.
The "Done" button should be disabled until the user translates any content, the same thing happens in the content translation tool.

image.png (386×455 px, 29 KB)

If I then click the edit button (pencil icon) it shows an empty canvas without the translation
image.png (300×461 px, 7 KB)

Once I'm in the "confirm publication" screen, if I click the "close" button (X icon) then the app flow goes in a loop and I can't leave the translation:
the X button leaves to the translation screen and the back arrow goes back to the "Confirm publication" screen.
image.png (236×419 px, 21 KB)

@ngkountas please let me know which of these issues is fixed on this task or in a new one.

@Jpita I create 2 separate tasks about the issues you reported: T269106, T269084. Please check if anything else should be added to these tickets (or another one).

@Jpita I create 2 separate tasks about the issues you reported: T269106, T269084. Please check if anything else should be added to these tickets (or another one).

awesome, thakns

One really small styling aspect to adjust in the future is the separation between the section title and the contents. Right now it feels a bit too much making elements feel disconnected.

The spec defines a 20px separation, but in the implementation the paragraphs come with their own top margin of 8px. So we may want to reduce the gap by taking into account the spacing added by the paragraphs.

Screenshot 2020-12-04 at 10.39.30.png (457×556 px, 58 KB)

This can be completed in a future ticket.