As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmadeo
	Aug 3 2020, 9:00 PM

Description

User story

As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model

Design details

This flow should follow closely the flow for thanking editors in the history view (on individual revisions). A prototype shows the basic features here: https://wikimedia.invisionapp.com/overview/History-and-Diffs-Testing---Wikimania-ck39lyx0o2ty8010jxbvysnv8/screens

Designs

Logged in

No action taken	User education (on first use of feature)	Confirmation	Re-tapping

https://zpl.io/bAM4pQe	https://zpl.io/adOP5Gn	https://zpl.io/V4WvxM4	https://zpl.io/a8MP44E

Logged out

No action taken	User education (on tap)

https://zpl.io/awKmekj	https://zpl.io/agArdJD

Related Objects
Search...

Status	Assigned	Task
Open	None	T241252 Editing Awareness and Trust Experiments
Resolved	• JMinor	T241253 Experiment: Article as a living document
Resolved	• JMinor	T259555 As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model

Event Timeline

cmadeo created this task.Aug 3 2020, 9:00 PM

LGoto triaged this task as Medium priority.Aug 4 2020, 6:47 PM

LGoto moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.7-Bonefish-On-A-Bus board.

LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

• MattCleinman mentioned this in T258209: [Dev]: UI work in modal.Aug 7 2020, 5:47 PM

cmadeo mentioned this in T241253: Experiment: Article as a living document.Aug 7 2020, 8:10 PM

LGoto edited projects, added iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat; removed iOS-app-v6.7-Bonefish-On-A-Bus.Sep 15 2020, 6:22 PM

LGoto edited projects, added iOS-app-v6.7.2-Bonefish-On-A-Balloon; removed iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat.Sep 22 2020, 6:45 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Sep 22 2020, 8:22 PM

• MattCleinman claimed this task.Oct 7 2020, 10:59 PM

• MattCleinman moved this task from Ready for Development to Doing on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.

Move tappedThank and associated unctions from DiffContainerViewController to a protocol and protocol extension.
Test that I didn't break anything in DiffContainerViewController.
Make Article as a Living Doc conform to new protocol.

• MattCleinman moved this task from Doing to Needs Code Review on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Oct 9 2020, 12:30 AM

https://github.com/wikimedia/wikipedia-ios/pull/3736

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Oct 21 2020, 4:31 PM

LGoto mentioned this in T267147: As a user I'd like to know if I have already thanked another editor and when.Nov 3 2020, 6:40 PM

Tsevener moved this task from Waiting for Build to Needs QA on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Nov 9 2020, 9:05 PM

Tsevener removed • MattCleinman as the assignee of this task.Nov 9 2020, 9:14 PM

Tsevener added a subscriber: • MattCleinman.

This is looking really good @MattClienman! Some small design bugs

On the 'Publicly send thanks' pop-up would it be possible to remove the blue boarder around the button? -- realizing this might be a bigger ask as it seems to be on all buttons of this style, so I can also file a separate ticket if that's better.
On an iPhoneX the success and other toasts are floating a bit above the bottom of the screen. Could we extend the fill of the toast to the bottom of the screen to avoid this little gap?

Looks good to me on 6.7.3.1785

Thanks!

	F31962294: 1a (logged out) - Thank flow - Article as a living document.png
	Aug 3 2020, 9:00 PM

	F31962286: 1 - Thank flow - Article as a living document.png
	Aug 3 2020, 9:00 PM

	F31962290: 4 (second tap) - Thank flow - Article as a living document.png
	Aug 3 2020, 9:00 PM

	F31962296: 2a (logged out) - Thank flow - Article as a living document.png
	Aug 3 2020, 9:00 PM

	F31962289: 3 (confirm) - Thank flow - Article as a living document.png
	Aug 3 2020, 9:00 PM

	F31962288: 2 (user edu) - Thank flow - Article as a living document.png
	Aug 3 2020, 9:00 PM

As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model Closed, ResolvedPublicActions