Page MenuHomePhabricator
Create Task
Maniphest T259630

TypeError: results.error is undefined
Closed, ResolvedPublic
Actions

Description

This is one of the more repeatable errors on mediawiki.org

Logstash URI

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Harden API error handling in showTranslationHelpersmediawiki/extensions/Translatemaster+3 -1
Harden response check in parse API error callbackmediawiki/extensions/Translatemaster+3 -1
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Aug 4 2020, 3:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2020, 3:42 PM
gerritbot added a comment.Aug 4 2020, 3:42 PM

Change 617837 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Translate@master] Harden translation test callback

https://gerrit.wikimedia.org/r/617837

gerritbot added a project: Patch-For-Review.Aug 4 2020, 3:42 PM
gerritbot added a comment.Aug 4 2020, 6:33 PM

Change 617837 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Harden response check in parse API error callback

https://gerrit.wikimedia.org/r/617837

Jdlrobson closed this task as Resolved.Aug 4 2020, 6:54 PM
Jdlrobson claimed this task.

Thanks for the review!

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 4 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 4 2020, 7:10 PM
gerritbot added a comment.Aug 31 2020, 10:08 PM

Change 623457 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Translate@master] Harden error handling

https://gerrit.wikimedia.org/r/623457

gerritbot added a project: Patch-For-Review.Aug 31 2020, 10:08 PM
Jdlrobson reopened this task as Open.Aug 31 2020, 10:12 PM

I missed one in my previous fix.

gerritbot added a comment.Sep 2 2020, 2:09 PM

Change 623457 merged by Abijeet Patro:
[mediawiki/extensions/Translate@master] Harden API error handling in showTranslationHelpers

https://gerrit.wikimedia.org/r/623457

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.8; 2020-09-08); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Sep 2 2020, 3:04 PM
Jdlrobson closed this task as Resolved.Sep 15 2020, 4:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits