Update WikimediaMessages to use HookHandlers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dbarratt
	Aug 4 2020, 6:19 PM

Description

Problem
WikimediaMessages uses the "old" Hook implementation system.

Proposed Solution
The extension should be updated to use HookHandler instead

Details

	Subject	Repo	Branch	Lines +/-
	Convert most core hook handling to use a HookHandler	mediawiki/extensions/WikimediaMessages	master	+180 -40

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Umherirrender	T335536 Hard deprecate class Hooks with all deprecated functions (and remove in 1.42)
Open	None	T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system
Open	None	T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system
Resolved	DannyS712	T259651 Update WikimediaMessages to use HookHandlers

Event Timeline

dbarratt created this task.Aug 4 2020, 6:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2020, 6:19 PM

@dbarratt happy to tackle this if you're willing to review. Note that it would require bumping the required version of MediaWiki from 1.34+ to 1.35+

In T259651#6360889, @DannyS712 wrote:

@dbarratt happy to tackle this if you're willing to review.

I'd be happy to review it. This task is a result of this comment: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/617830/1/extension.json#57

Note that it would require bumping the required version of MediaWiki from 1.34+ to 1.35+

Since this extension only runs on Wikimedia, I think that's totes fine.

DannyS712 claimed this task.Aug 4 2020, 7:46 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 4 2020, 7:46 PM

Change 618299 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMessages@master] Convert hook handling to use a HookHandler

https://gerrit.wikimedia.org/r/618299

gerritbot added a project: Patch-For-Review.Aug 4 2020, 7:46 PM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Aug 4 2020, 9:16 PM

dbarratt added a project: Anti-Harassment (The Letter Song).Aug 5 2020, 4:32 PM

dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Change 618299 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Convert most core hook handling to use a HookHandler

https://gerrit.wikimedia.org/r/618299

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 5:10 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 10 2020, 6:00 AM

DannyS712 closed this task as Resolved.Aug 10 2020, 7:44 AM

Tchanders removed a project: Anti-Harassment (The Letter Song).Aug 10 2020, 3:26 PM

MarcoAurelio moved this task from Backlog to Closed on the WikimediaMessages board.Aug 31 2020, 10:41 AM