[Bug] SonarQube bot is not working for push-notifications service
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MSantos
	Aug 4 2020, 7:23 PM

Description

Steps to Reproduce

Submit a patch
See that scan is working fine for revision-patchset in https://sonarcloud.io/dashboard?id=mediawiki-services-push-notifications

Expected Results

After the scan is complete the SonarQube bot should comment in the gerrit patch

Actual Results

SonarQube does not comment in the gerrit patch

Additional notes

@kostajh identified that the bot is getting 400 status when attempting to post the comment [1]

[2020-07-22T07:48:14.710609+00:00] app.ERROR: HTTP/1.1 400 Bad Request returned for "https://gerrit.wikimedia.org/r/a/changes/mediawiki%2Fservices%2Fpush-notifications~604830/revisions/23/review". [] []

[1] https://gerrit.wikimedia.org/r/c/mediawiki/services/push-notifications/+/604830/29#message-f5f0929947d6f9f0ec3ee6bdc2c2cd00cbfde325

Related Objects
Search...

Status	Assigned	Task
Resolved	sbassett	T251190 Security Request For Service - Push Notifications
Resolved	• Mholloway	T262936 Enable app push notifications in production
Resolved	• Gilles	T246707 Performance review of push notifications infrastructure
Resolved	sbassett	T246712 Security Readiness Review for push notifications infrastructure
Declined	None	T251442 Add PushNotifications extension to release branch cut
Declined	None	T251596 Document PushNotifications extension on mediawiki.org
Resolved	• Mholloway	T251437 Create MediaWiki extension for Push Notifications
Resolved	MSantos	T251441 CI and test coverage
Resolved	kostajh	T259658 [Bug] SonarQube bot is not working for push-notifications service

Event Timeline

MSantos created this task.Aug 4 2020, 7:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2020, 7:23 PM

MSantos moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 4 2020, 7:24 PM

MSantos added a parent task: T251441: CI and test coverage.

MSantos triaged this task as Medium priority.Aug 5 2020, 12:07 PM

@thcipriani @hashar is it possible that there is some more detail in the Gerrit logs that would explain what is wrong with the POST request?

kostajh added a project: User-kostajh.Aug 14 2020, 7:54 AM

I don't see anything in the gerrit error log for the date in question afaict; which makes sense for 400-level error to me.

More recent patchsets seem to have comment from sonarqubebot: https://gerrit.wikimedia.org/r/c/mediawiki/services/push-notifications/+/621031/1#message-cb9a227b2a11eaf214d49daedc3a09a68645edbe

Did this already get resolved?

Hmm, I didn't change anything in the SonarQube Bot code. There are a fair number of "400 Bad Request" errors in the logs for various repositories (161, although there are some duplicates there due to additional logging I added). I guess we can close this and reopen if the problem becomes reproducible again.

MSantos awarded a token.Aug 19 2020, 8:31 AM

There are a few errors 400 in the Apache access log around 2020-07-22T07:48:14, though nothing matching that specific URL. So yeah that is a mystery :-\

Meh, I'm now seeing this same issue with T266110: Add Link engineering: Codehealth integration

[Bug] SonarQube bot is not working for push-notifications serviceClosed, ResolvedPublicActions