Page MenuHomePhabricator
Create Task
Maniphest T259676

Exception in References.php: PHP Notice: Undefined property: stdClass::$extsrc
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.2

message
PHP Notice: Undefined property: stdClass::$extsrc

Impact

Notes

Details

Request ID
ec4ed74e-1c7f-4436-91ba-03df42b87a79
Request URL
https://en.wikipedia.org/w/rest.php/en.wikipedia.org/v3/page/pagebundle/Talk%3AJon_Nelson_(guitarist)/880177409
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Ext/Cite/References.php(163): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Ext/Cite/References.php(434): Wikimedia\Parsoid\Ext\Cite\References::extractRefFromNode(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, DOMElement, Wikimedia\Parsoid\Ext\Cite\ReferencesData)
#2 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Ext/Cite/References.php(417): Wikimedia\Parsoid\Ext\Cite\References::processRefs(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, Wikimedia\Parsoid\Ext\Cite\ReferencesData, DOMElement)
#3 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Ext/Cite/References.php(450): Wikimedia\Parsoid\Ext\Cite\References::processEmbeddedRefs(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, Wikimedia\Parsoid\Ext\Cite\ReferencesData, string)
#4 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Ext/ParsoidExtensionAPI.php(470): Wikimedia\Parsoid\Ext\Cite\References::Wikimedia\Parsoid\Ext\Cite\{closure}(string)
#5 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Ext/Cite/References.php(451): Wikimedia\Parsoid\Ext\ParsoidExtensionAPI->processHiddenHTMLInDataAttributes(DOMElement, Closure)
#6 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Ext/Cite/RefProcessor.php(23): Wikimedia\Parsoid\Ext\Cite\References::processRefs(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, Wikimedia\Parsoid\Ext\Cite\ReferencesData, DOMElement)
#7 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(165): Wikimedia\Parsoid\Ext\Cite\RefProcessor->wtPostprocess(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, DOMElement, array, boolean)
#8 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(847): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->Wikimedia\Parsoid\Wt2Html\{closure}(DOMElement, array, boolean)
#9 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(896): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->doPostProcess(DOMDocument)
#10 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(913): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->process(DOMDocument)
#11 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(152): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#12 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(202): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#13 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(299): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseToplevelDoc(string, array)
#14 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(78): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#15 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Parsoid.php(152): Wikimedia\Parsoid\Core\WikitextContentModelHandler->toDOM(Wikimedia\Parsoid\Config\Env)
#16 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/src/Parsoid.php(184): Wikimedia\Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#17 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(568): Wikimedia\Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array, NULL)
#18 /srv/mediawiki/php-1.36.0-wmf.2/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(90): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(MWParsoid\Config\PageConfig, array)
#19 /srv/mediawiki/php-1.36.0-wmf.2/includes/Rest/Router.php(365): MWParsoid\Rest\Handler\PageHandler->execute()
#20 /srv/mediawiki/php-1.36.0-wmf.2/includes/Rest/Router.php(320): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#21 /srv/mediawiki/php-1.36.0-wmf.2/includes/Rest/EntryPoint.php(133): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#22 /srv/mediawiki/php-1.36.0-wmf.2/includes/Rest/EntryPoint.php(100): MediaWiki\Rest\EntryPoint->execute()
#23 /srv/mediawiki/php-1.36.0-wmf.2/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#24 /srv/mediawiki/w/rest.php(3): require(string)
#25 {main}
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to v0.13.0-a6mediawiki/vendormaster+462 -231
Fix for missing content check where ..body->extsrc is undefinedmediawiki/services/parsoidmaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Aug 5 2020, 1:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2020, 1:33 AM
ssastry assigned this task to Sbailey.Aug 5 2020, 2:08 AM
ssastry triaged this task as Medium priority.
ssastry moved this task from Needs Triage to Current & Upcoming Work on the Parsoid board.
gerritbot added a comment.Aug 5 2020, 6:28 PM

Change 618565 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Fix for missing content check where ..body->extsrc is undefined

https://gerrit.wikimedia.org/r/618565

gerritbot added a project: Patch-For-Review.Aug 5 2020, 6:28 PM
ssastry mentioned this in T260082: Handling extension tags in HTML attributes (edge cases or otherwise).Aug 10 2020, 6:40 PM
gerritbot added a comment.Aug 10 2020, 10:02 PM

Change 618565 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Fix for missing content check where ..body->extsrc is undefined

https://gerrit.wikimedia.org/r/618565

ssastry closed this task as Resolved.Aug 10 2020, 10:03 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 10:10 PM
gerritbot added a comment.Aug 17 2020, 5:30 PM

Change 620755 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a6

https://gerrit.wikimedia.org/r/620755

gerritbot added a project: Patch-For-Review.Aug 17 2020, 5:30 PM
gerritbot added a comment.Aug 17 2020, 6:31 PM

Change 620755 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a6

https://gerrit.wikimedia.org/r/620755

Arlolra subscribed.Mar 25 2021, 3:29 PM

Note that this just kicked the can down the road and the problem is now manifesting as T278402

But I guess we'll fix it in T260082

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL