Page MenuHomePhabricator
Create Task
Maniphest T259685

Zeroconf VisualEditor/Parsoid doesn't work on SQLite
Closed, ResolvedPublic
Actions

Description

I was testing the MediaWiki-Debian package (though I believe it's applicable to vanilla MediaWiki) and discovered that VE/Parsoid isn't working on SQLite. Read requests seem to work, in that I'm able to open the editor, change stuff, but when I try to save, I get Error contacting the Parsoid/RESTBase server: (curl error: 28) Timeout was reached.

My hunch is that the loopback is causing a problem in that the first API action=visualeditoredit request holds some lock on the database, and then the loopback request times out because it can't get the lock.

Everything works fine on MySQL.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Aug 5 2020, 5:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2020, 5:04 AM
cscott added a parent task: T248343: Uncached VisualEditor w/ Parsoid/PHP (no JS, no RESTBase) for MW 1.35 LTS.Aug 5 2020, 5:19 AM
Arlolra subscribed.Aug 5 2020, 1:50 PM

Yeah, this was a problem with Parsoid/JS and SQLite as well,
https://www.mediawiki.org/wiki/Topic:Vde0xothlxmwzg2y

ssastry moved this task from Needs Triage to Non-Wikimedia Parsoid usecases on the Parsoid board.Aug 5 2020, 9:47 PM
Legoktm added a comment.Aug 5 2020, 11:36 PM

Confirmed that it's an issue with not being able to open the database while another request has it open. My debug log hangs at:

[DBConnection] Wikimedia\Rdbms\LoadBalancer::getLocalConnection: opened new connection for 0

and then after a while I'll see:

[http] Error fetching URL "http://localhost:4881/rest.php/localhost/v3/transform/html/to/wikitext/Main_Page/6": (curl error: 28) Timeout was reached

My understanding is that SQLite by default has no write concurrency, but I'm not sure about reads...

ssastry added subscribers: cscott, ssastry.Aug 6 2020, 12:29 AM

Both @cscott and I were wondering why we need to support SQLite. Is this a real use case out there? I say we don't bother with this.

Legoktm added a subscriber: tstarling.EditedAug 6 2020, 12:43 AM
In T259685#6364679, @ssastry wrote:

Both @cscott and I were wondering why we need to support SQLite. Is this a real use case out there? I say we don't bother with this.

SQLite is one of the 3 supported database engines by MediaWiki and it's a requirement that it (along with MySQL/Postgres) be supported for inclusion in the tarball. We currently don't have any mechanism in the installer to indicate that an extension doesn't support a particular database engine.

@tstarling and I also discussed this on IRC, he pointed out that SQLite doesn't handle concurrency well and that in his experience, upstream isn't interested in fixing it and his position is that people using SQLite should just move to MySQL. I think that's fine as a long-term goal but doesn't fix our current problem.

I'll keep taking stabs at this in any case since I actually run a SQLite MediaWiki instance in "production".

Krenair subscribed.Aug 6 2020, 1:11 AM
cscott added a comment.Aug 6 2020, 1:24 AM

We could potentially just tweak the message associated with sqlite. Eg config-dbsupport-sqlite in en.json says:

* [{{int:version-db-sqlite-url}} SQLite] is a lightweight database system that is very well supported. ([https://www.php.net/manual/en/pdo.installation.php How to compile PHP with SQLite support], uses PDO)

You could add something like, "however, it does not support VisualEditor", to that message.

There is also a config-outdated-sqlite message warnings about outdated SQLite; you could imagine something similar that just warned that VisualEditor isn't supported if sqlite is selected.

cscott added a comment.Aug 6 2020, 1:32 AM

Maybe look at some of the advice in https://www.mediawiki.org/wiki/User:Aaron_Schulz/How_to_make_MediaWiki_fast ?

cscott added a comment.EditedAug 6 2020, 1:38 AM

Perhaps $wgJobRunRate is the culprit. If it is > 0, then jobs are going to be run on both the VE action API request and the Parsoid REST API request (as I understand it), and those jobs could fight with Parsoid for a db lock.

Legoktm mentioned this in T259693: VisualEditor triggers HTTP 500 Parsoid error on Windows because of exception in GlobalIdGenerator.Aug 7 2020, 9:46 PM
Lens0021 mentioned this in T261156: Extension Parsoid is not loaded automatically.Aug 24 2020, 6:28 PM
gerritbot added a comment.Aug 25 2020, 4:18 AM

Change 622258 had a related patch set uploaded (by Lens0021; owner: Lens0021):
[mediawiki/extensions/Flow@master] Do not throw exception for zero-conf Parsoid

https://gerrit.wikimedia.org/r/622258

gerritbot added a project: Patch-For-Review.Aug 25 2020, 4:18 AM
Lens0021 removed a project: Patch-For-Review.Aug 25 2020, 4:21 AM
Lens0021 subscribed.

Sorry, I mistakenly uploaded the patch

cscott mentioned this in T259452: Release parsoid 0.12.0 and bump it in REL1_35.Aug 26 2020, 12:56 PM

@Legoktm any progress on this? It seems like any fix is going to miss the 1.35 train if we don't figure it out soon.

cscott mentioned this in T259349: Finish up RELEASE-NOTES for 1.35.0.Aug 26 2020, 1:19 PM
Arlolra added a comment.Aug 26 2020, 4:08 PM

Might be related to T118629. If you can reproduce, try setting $wgMessageCacheType = CACHE_NONE;

Legoktm added a comment.Aug 26 2020, 8:20 PM
In T259685#6412134, @cscott wrote:

@Legoktm any progress on this? It seems like any fix is going to miss the 1.35 train if we don't figure it out soon.

My rough idea was to have VRS (or some other layer) call the rest API internally (similar to the action API), but that's more difficult than it looks and I just haven't gotten to it yet. I don't think we should treat this as a blocker for 1.35 anymore, but if/when a solution comes we should backport it.

In T259685#6413174, @Arlolra wrote:

Might be related to T118629. If you can reproduce, try setting $wgMessageCacheType = CACHE_NONE;

That didn't help. My understanding is that SQLite grabs a lock on all POST requests, so the first POST to api.php?action=visualeditoredit gets the lock and then the next internal POST to rest.php/... can't get the lock.

cscott added a comment.Aug 26 2020, 9:06 PM

Ah. That's T93097 then, includes/db/MWLBFactory.php. Wouldn't be too hard to hack Parsoid requests to be 'isHttpRead' because although the /transform/ end points are POSTs we don't have side effects on the DB.

gerritbot added a comment.Aug 26 2020, 9:43 PM

Change 622663 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Allow REST API POST handlers to opt out of mandatory sqlite locking

https://gerrit.wikimedia.org/r/622663

gerritbot added a project: Patch-For-Review.Aug 26 2020, 9:43 PM
cscott added a comment.EditedAug 26 2020, 9:45 PM

@Legoktm could you take a look at the above and see if it fixes the issue? It might still run into problems if the POST to action=visualeditoredit prevents even read access from Parsoid's REST API, but it might work, or at least suggest an avenue to a solution. I've no pride in authorship there, feel free to takeover the patch and hack it until it actually works properly...

EDIT: oh, and you'll need https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/622665 as well on the Parsoid side to make the above patch "do something".

kostajh mentioned this in T261390: Zeroconf Parsoid + VisualEditor doesn't work with MediaWiki-Docker.Aug 27 2020, 10:14 AM
ppelberg added a project: Editing-team (Tracking).Aug 27 2020, 4:09 PM
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.
matmarex subscribed.Aug 27 2020, 7:07 PM
DLynch subscribed.Sep 8 2020, 1:15 PM
Reedy added a project: Platform Team Workboards (External Code Reviews).Sep 11 2020, 3:49 PM
daniel triaged this task as Medium priority.Sep 18 2020, 12:58 PM
Reedy renamed this task from Zeroconf VisualEditor/Parsoid doesn't seem to work on SQLite to Zeroconf VisualEditor/Parsoid doesn't work on SQLite .Sep 23 2020, 10:13 PM
gerritbot added a comment.Sep 23 2020, 10:17 PM

Change 629401 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] RELEASE-NOTES-1.35: Note that Zeroconf VisualEditor/Parsoid doesn't work on SQLite

https://gerrit.wikimedia.org/r/629401

gerritbot added a comment.Sep 23 2020, 11:00 PM

Change 629404 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] RELEASE-NOTES-1.35: Note that Zeroconf VisualEditor/Parsoid doesn't work on SQLite

https://gerrit.wikimedia.org/r/629404

gerritbot added a comment.Sep 23 2020, 11:08 PM

Change 629404 merged by jenkins-bot:
[mediawiki/core@REL1_35] RELEASE-NOTES-1.35: Note that Zeroconf VisualEditor/Parsoid doesn't work on SQLite

https://gerrit.wikimedia.org/r/629404

gerritbot added a comment.Sep 23 2020, 11:24 PM

Change 629401 merged by jenkins-bot:
[mediawiki/core@master] RELEASE-NOTES-1.35: Note that Zeroconf VisualEditor/Parsoid doesn't work on SQLite

https://gerrit.wikimedia.org/r/629401

ReleaseTaggerBot added projects: MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 24 2020, 12:00 AM
DLynch mentioned this in T265164: Evaluate usage of MediaWiki-Vagrant by technical contributors.Oct 13 2020, 5:24 AM
• Demian added a parent task: T266971: "Error contacting the Parsoid/RESTBase server" (HTTP 404/403) and similar errors (catalog).Nov 1 2020, 8:27 PM
jberkel subscribed.Nov 23 2020, 12:59 AM

SQLite might not be your typical production setup, but it's very handy for getting a MediaWiki instance up and running in a docker container, I'm using it to process Wiktionary data. After switching to Parsoid the performance suffered quite noticeably, related to the aggressive write locking mentioned above.

Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.Dec 2 2020, 1:59 AM
MBinder_WMF edited projects, added Parsoid (Third-party); removed Parsoid.Dec 10 2020, 8:23 PM
gerritbot added a comment.Feb 2 2021, 11:03 PM

Change 661213 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@master] Fix sqlite compatibility by opting out of obligatory write lock

https://gerrit.wikimedia.org/r/661213

cscott added a comment.Feb 3 2021, 9:04 PM

Ok, the pair of patches (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/622663 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/661213) actually fix the problem, according to @DLynch's testing. Sorry it took a while to get that right.

gerritbot added a comment.Feb 3 2021, 9:38 PM

Change 622663 merged by jenkins-bot:
[mediawiki/core@master] Allow REST API POST handlers to opt out of mandatory sqlite locking

https://gerrit.wikimedia.org/r/622663

gerritbot added a comment.Feb 3 2021, 9:38 PM

Change 661213 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix sqlite compatibility by opting out of obligatory write lock

https://gerrit.wikimedia.org/r/661213

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.30; 2021-02-09); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Feb 3 2021, 10:00 PM
gerritbot added a comment.Feb 4 2021, 5:54 PM

Change 661763 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@master] Rename magic header to be consistent with WMF CDN infrastructure

https://gerrit.wikimedia.org/r/661763

gerritbot added a comment.Feb 4 2021, 5:55 PM

Change 661760 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] MWLBFactory: rename magic HTTP header for opting out of sqlite write lock

https://gerrit.wikimedia.org/r/661760

gerritbot added a comment.Feb 4 2021, 11:38 PM

Change 661760 merged by jenkins-bot:
[mediawiki/core@master] MWLBFactory: rename magic HTTP header for opting out of sqlite write lock

https://gerrit.wikimedia.org/r/661760

gerritbot added a comment.Feb 4 2021, 11:38 PM

Change 661763 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Rename magic header to be consistent with WMF CDN infrastructure

https://gerrit.wikimedia.org/r/661763

matmarex closed this task as Resolved.Feb 5 2021, 12:46 PM
matmarex assigned this task to cscott.

Sounds like it's resolved!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 5 2021, 12:46 PM
gerritbot added a comment.Feb 5 2021, 9:03 PM

Change 661933 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@REL1_35] Allow REST API POST handlers to opt out of mandatory sqlite locking

https://gerrit.wikimedia.org/r/661933

gerritbot added a comment.Feb 5 2021, 9:06 PM

Change 661934 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@REL1_35] MWLBFactory: rename magic HTTP header for opting out of sqlite write lock

https://gerrit.wikimedia.org/r/661934

gerritbot added a comment.Feb 5 2021, 9:09 PM

Change 661935 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@REL1_35] Fix sqlite compatibility by opting out of obligatory write lock

https://gerrit.wikimedia.org/r/661935

gerritbot added a comment.Feb 5 2021, 9:11 PM

Change 661936 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@REL1_35] Rename magic header to be consistent with WMF CDN infrastructure

https://gerrit.wikimedia.org/r/661936

gerritbot added a comment.Feb 16 2021, 5:55 PM

Change 661933 merged by jenkins-bot:
[mediawiki/core@REL1_35] Allow REST API POST handlers to opt out of mandatory sqlite locking

https://gerrit.wikimedia.org/r/661933

gerritbot added a comment.Feb 16 2021, 5:55 PM

Change 661934 merged by jenkins-bot:
[mediawiki/core@REL1_35] MWLBFactory: rename magic HTTP header for opting out of sqlite write lock

https://gerrit.wikimedia.org/r/661934

gerritbot added a comment.Feb 16 2021, 6:29 PM

Change 661935 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@REL1_35] Fix sqlite compatibility by opting out of obligatory write lock

https://gerrit.wikimedia.org/r/661935

gerritbot added a comment.Feb 16 2021, 6:29 PM

Change 661936 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@REL1_35] Rename magic header to be consistent with WMF CDN infrastructure

https://gerrit.wikimedia.org/r/661936

matmarex edited projects, added Editing-team (Third-party); removed Editing-team (Tracking).Feb 17 2021, 10:31 AM
gerritbot added a comment.Apr 8 2021, 7:45 PM

Change 678030 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_35] SQLite compatibility with ZeroConf VisualEditor was fixed in 1.35.2

https://gerrit.wikimedia.org/r/678030

gerritbot added a comment.Apr 8 2021, 9:54 PM

Change 678030 merged by jenkins-bot:

[mediawiki/core@REL1_35] SQLite compatibility with ZeroConf VisualEditor was fixed in 1.35.2

https://gerrit.wikimedia.org/r/678030

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits