Page MenuHomePhabricator
Create Task
Maniphest T259697

Migrate ResourceLoaderTestModules hook in Wikibase to QUnitTestModule
Closed, ResolvedPublic
Actions

Description

See the parent task.

Details

SubjectRepoBranchLines +/-
Migrate last qunit modules of view to QUnitTestModulemediawiki/extensions/Wikibasemaster+50 -149
Final set of migrating repo qunit test modules to QUnitTestModulemediawiki/extensions/Wikibasemaster+14 -76
Make qunit RL module of repo use package modulesmediawiki/extensions/Wikibasemaster+76 -1
Change the qunit test module to depend on WikibaseRepo qunit modulemediawiki/extensions/WikibaseLexememaster+1 -2
Remove migrated qunit RL modulesmediawiki/extensions/Wikibasemaster+0 -57
Migrate several RL qunit modules to QUnitTestModulemediawiki/extensions/Wikibasemaster+7 -0
Migrate several more test RL modules to QUnitTestModulemediawiki/extensions/Wikibasemaster+13 -58
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Aug 5 2020, 11:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2020, 11:47 AM
Ladsgroup claimed this task.Aug 6 2020, 8:16 PM
Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 4) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 6 2020, 8:16 PM
gerritbot added a comment.Aug 6 2020, 8:37 PM

Change 618848 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Migrate several more test RL modules to QUnitTestModule

https://gerrit.wikimedia.org/r/618848

gerritbot added a project: Patch-For-Review.Aug 6 2020, 8:37 PM
gerritbot added a comment.Aug 6 2020, 9:03 PM

Change 618857 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Migrate several RL qunit modules to QUnitTestModule

https://gerrit.wikimedia.org/r/618857

gerritbot added a comment.Aug 6 2020, 9:06 PM

Change 618859 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Change the qunit test module to depend on WikibaseRepo qunit module

https://gerrit.wikimedia.org/r/618859

gerritbot added a comment.Aug 6 2020, 9:50 PM

Change 618864 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Remove migrated qunit RL modules

https://gerrit.wikimedia.org/r/618864

Ladsgroup moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 4) board.Aug 6 2020, 9:56 PM
Ladsgroup added a comment.Aug 6 2020, 9:58 PM

These patches won't finish it but it fixes everything up to the point of the need to use package modules. For that, I will do something slightly complicated so let's first get these in and then we move to that one.

gerritbot added a comment.Aug 7 2020, 10:11 AM

Change 618848 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate several more test RL modules to QUnitTestModule

https://gerrit.wikimedia.org/r/618848

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 7 2020, 11:00 AM
gerritbot added a comment.Aug 7 2020, 12:30 PM

Change 618973 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Make qunit RL module of repo use package modules

https://gerrit.wikimedia.org/r/618973

gerritbot added a comment.Aug 7 2020, 1:34 PM

Change 618982 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Final set of migrating repo qunit test modules to QUnitTestModule

https://gerrit.wikimedia.org/r/618982

gerritbot added a comment.Aug 7 2020, 1:48 PM

Change 618857 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate several RL qunit modules to QUnitTestModule

https://gerrit.wikimedia.org/r/618857

gerritbot added a comment.Aug 7 2020, 1:48 PM

Change 618859 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Change the qunit test module to depend on WikibaseRepo qunit module

https://gerrit.wikimedia.org/r/618859

gerritbot added a comment.Aug 7 2020, 1:49 PM

Change 618864 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove migrated qunit RL modules

https://gerrit.wikimedia.org/r/618864

gerritbot added a comment.Aug 7 2020, 5:15 PM

Change 619016 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Migrate last qunit modules of view to QUnitTestModule

https://gerrit.wikimedia.org/r/619016

gerritbot added a comment.Aug 11 2020, 12:12 PM

Change 618973 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make qunit RL module of repo use package modules

https://gerrit.wikimedia.org/r/618973

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 11 2020, 1:00 PM
Ladsgroup closed this task as Resolved.Aug 12 2020, 9:58 AM
Ladsgroup moved this task from Peer Review to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board.
Jdforrester-WMF subscribed.Aug 12 2020, 10:03 AM

There's still a use of the hook in Wikibase repo: https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/081e56e45bb6b00546cdcab05014ea6c3fad21f0/extension-repo.json#468

Ladsgroup added a comment.Aug 12 2020, 10:04 AM
In T259697#6379047, @Jdforrester-WMF wrote:

There's still a use of the hook in Wikibase repo: https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/081e56e45bb6b00546cdcab05014ea6c3fad21f0/extension-repo.json#468

Sorry, I'm a little excited, the patch is in gate-submit :D

Jdforrester-WMF added a comment.Aug 12 2020, 10:05 AM

Ha.

gerritbot added a comment.Aug 12 2020, 10:10 AM

Change 618982 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Final set of migrating repo qunit test modules to QUnitTestModule

https://gerrit.wikimedia.org/r/618982

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Aug 12 2020, 10:15 AM
gerritbot added a comment.Aug 12 2020, 10:21 AM

Change 619016 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate last qunit modules of view to QUnitTestModule

https://gerrit.wikimedia.org/r/619016

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2020, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL