Page MenuHomePhabricator

Replace usage of ResourceLoaderTestModules hook in MobileFrontend?
Closed, ResolvedPublic

Description

ResourceLoaderTestModules hook is deprecated and almost all deployed extensions are migrated (see checklist in parent task).

It seems MobileFrontend was initially using QUnitTestModule attribute (the recommended alternative) but was purposely changed to use this hook r499533 for reasons mentioned there . Also, the change was after the hook deprecation, so not sure whether that's intentional too.

Event Timeline

Jdlrobson added a project: Readers-Web-Backlog.

I would suggest dropping the tests inside the special page and relying on npm test. To my knowledge nobody is actually using the former.

Ammarpad triaged this task as Medium priority.

I would suggest dropping the tests inside the special page and relying on npm test. To my knowledge nobody is actually using the former.

OK

Change 619758 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Drop JavaScriptTest tests suite

https://gerrit.wikimedia.org/r/619758

Change 619758 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Drop JavaScriptTest tests suite

https://gerrit.wikimedia.org/r/619758

Change 692027 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: cleanup tests.mobilefrontend

https://gerrit.wikimedia.org/r/692027

Change 692027 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: cleanup tests.mobilefrontend

https://gerrit.wikimedia.org/r/692027