Page MenuHomePhabricator

Consistent casing for command arguments
Open, LowPublic

Description

@cscott in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/618173/1//COMMIT_MSG,

I was wondering if we should rename --updateKnownFailures to --update-known-failures. The latter seems to be the more consistent form in our parserTests (--exit-unexpected, --exit-zero, --update-tests, --update-unexpected, --run-disabled, --run-php) and core's parserTests.php uses the all-lower convention consistently (--show-output, --keep-uploads, --file-backend, --upload-dir, --run-disabled, --disable-save-parse, --mark-ws, --use-tidy-config).

Parsoid's parserTests only has --offsetType, --knownFailures, --updateKnownFailures in StudlyCaps.

However, the "standard options" of Parsoid also have --fetchConfig, fetchTemplates, --fetchImageInfo, --expandExtensions, --usePHPPreProcessor, --addHTMLTemplateParameters, --apiURL, and --rtTestMode. (We're you saying something the other day about getting rid of standard options? These are accepted by parserTests but don't really have any useful effect.)

And there are a bunch of wordssmashedtogether options which don't fit either pattern. In Parsoid parserTests.php: --changetree, --numchanges, --maxtests. In Parsoid standard options, --maxdepth. In core's parserTests.php: --setversion.