Page MenuHomePhabricator

Notification page design fixes
Closed, ResolvedPublic5 Estimated Story Points

Description

Page: https://api.wikimedia.beta.wmflabs.org/wiki/Special:Notifications

Expected behavior: Notifications page on mediawiki.org](https://www.mediawiki.org/wiki/Special:Notifications)

Observed behavior: The preferences menu is partially hidden. There's a missing space between the day and the date. And the "Mark as read" button obstructs the line under the date.

Screenshots:



Event Timeline

I also noticed that the notification UI gets pushed down due to the sidebar at around 1080px width:

Helga_sf set the point value for this task to 2.Aug 27 2020, 12:04 PM
Helga_sf changed the point value for this task from 2 to 5.

Change 623339 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/extensions/Echo@master] Menu fix

https://gerrit.wikimedia.org/r/623339

If possible, I'd prefer that the fix for this issue be done within the WikimediaApiPortal skin instead of in any existing extensions

As discussed:

  • Fix for preferences menu is made in "Echo" (Notification) extension as there is no other relevant solution for now due to the current architecture.
  • Fix for notification UI "Recent activities" blcok is made in the WikimediaApiPortal skin itself.

Update:

  • Fix for preferences menu is made in "Echo" (Notification) extension with the help of additional skin specific (WikimediaApiPortal in this case) that is better solution, than updating "common" css file.

Change 623772 had a related patch set uploaded (by Cicalese; owner: arttsymbar):
[mediawiki/skins/WikimediaApiPortal@master] WikimediaApiPortal, Notifications: notification UI - Recent activity block width fix for less than 1200px resolution.

https://gerrit.wikimedia.org/r/623772

Change 623772 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] WikimediaApiPortal, Notifications: notification UI - Recent activity block width fix for less than 1200px resolution.

https://gerrit.wikimedia.org/r/623772

Change 623339 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Notification: add skin specific(WikimediaApiPortal) z-index for menu overlay

https://gerrit.wikimedia.org/r/623339

@Art.tsymbar On beta, I see the issue with the preferences menu being hidden is now fixed!

As for the issue with the recent activity block width fix, when I test 623772 locally, the issue is fixed. However, I'm still seeing the original issue when I test on the beta site.

@apaskulin Do you mean https://api.wikimedia.beta.wmflabs.org/wiki/Special:Notifications ? Seems I do not have enough permissions. Do you know how can I get them or some other way for me to reproduce the issue on the Beta ? Thanks.

After trying out Art's alternative fix for this and re-testing on beta, I've decided that the current state of this task works for me. We don't need any further work on this task. Verifying and resolving. Thanks, Art!