Page MenuHomePhabricator

Review identifiers schema fragment (Shay)
Closed, ResolvedPublic

Description

Please review core identifiers patch https://gerrit.wikimedia.org/r/615559

Specific things to look for / think about:

  • clarity of field descriptions, if there's any ambiguity
  • whether it's okay for this schema fragment to reference /fragments/analytics/common fragment and declare client_dt as required (the intention is to avoid referencing both every time, since any schema that would be using this fragment will be using client_dt anyway)

Note: T259714 is blocked until the identifiers fragment is available for use in schemas

Details

Due Date
Aug 20 2020, 4:00 AM

Event Timeline

mpopov triaged this task as High priority.Aug 5 2020, 8:13 PM
mpopov created this task.
mpopov renamed this task from Review identifiers schema fragment to Review identifiers schema fragment (Shay).Aug 5 2020, 8:16 PM

This looks good to me. Signing off as approved.

mpopov changed Due Date from Aug 13 2020, 4:00 AM to Aug 20 2020, 4:00 AM.Aug 13 2020, 9:22 PM