Page MenuHomePhabricator

Review identifiers schema fragment (Neil)
Closed, ResolvedPublic


Please review core identifiers patch

Specific things to look for / think about:

  • clarity of field descriptions, if there's any ambiguity
  • whether it's okay for this schema fragment to reference /fragments/analytics/common fragment and declare client_dt as required (the intention is to avoid referencing both every time, since any schema that would be using this fragment will be using client_dt anyway)

Note: T259714 is blocked until the identifiers fragment is available for use in schemas


Due Date
Aug 20 2020, 4:00 AM

Event Timeline

mpopov triaged this task as High priority.Aug 5 2020, 8:13 PM
mpopov created this task.
mpopov renamed this task from Review identifiers schema fragment to Review identifiers schema fragment (Neil).Aug 5 2020, 8:16 PM
mpopov changed Due Date from Aug 13 2020, 4:00 AM to Aug 20 2020, 4:00 AM.Aug 13 2020, 9:22 PM

After lots of fruitful discussion and 10 patchsets, I have totally run out of things to critique and must therefore resign myself to being pleased with the outcome. I guess that means this is done! 😂