Reduce space between sidebar and content
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Currently the minimum amount of space between the sidebar and the content is ~68px. This only becomes apparent when the browser window is smaller than 1440px.

We want to reduce this minimum amount of space to 46px. I believe this change will require us to also update the value of the breakpoint, which is currently 1440px.

Developer Notes

This should be as simple as adjusting the @margin-start-content variable in layout-max-width.less. [1]
Note that there is 8 pixels of horizontal padding on the tabs and content. This may need to be factored into the calculation.

[1] https://github.com/wikimedia/Vector/blob/f6a1d21af127cd17b35011e403746c9d2411403c/resources/skins.vector.styles/layout-max-width.less#L25

QA Results - Beta

AC	Status	Details
1	✅	T259761#6434616

QA Results - Prod

AC	Status	Details
1	✅	T259761#6452613

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/Vector	master	+1 -1	Reduce space between sidebar and content

Customize query in gerrit

Related Objects

Mentioned In: T259083: [Regression] UI regressions in VE on Beta cluster

Event Timeline

alexhollender created this task.Aug 5 2020, 10:31 PM

ovasileva triaged this task as High priority.Aug 6 2020, 1:58 PM

ovasileva edited projects, added Readers-Web-Backlog (Kanbanana-FY-2020-21); removed Readers-Web-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.Aug 6 2020, 4:06 PM

nray updated the task description. (Show Details)Aug 6 2020, 4:23 PM

nray updated the task description. (Show Details)Aug 6 2020, 4:33 PM

Jdlrobson set the point value for this task to 2.Aug 19 2020, 5:19 PM

Jdlrobson moved this task from Upcoming to Ready for Development on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.Aug 19 2020, 5:24 PM

Jdrewniak claimed this task.Aug 27 2020, 1:43 PM

Jdrewniak moved this task from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Change 624023 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/Vector@master] Reduce space between sidebar and content

https://gerrit.wikimedia.org/r/624023

gerritbot added a project: Patch-For-Review.Sep 3 2020, 11:20 AM

Jdrewniak moved this task from Doing to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.Sep 3 2020, 11:21 AM

Jdrewniak removed Jdrewniak as the assignee of this task.Sep 3 2020, 4:16 PM

Jdrewniak added a subscriber: Jdrewniak.

Jdlrobson assigned this task to Edtadros.Sep 3 2020, 5:02 PM

Jdlrobson moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Change 624023 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Reduce space between sidebar and content

https://gerrit.wikimedia.org/r/624023

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 3 2020, 6:00 PM

Mhurd claimed this task.Sep 3 2020, 8:39 PM

Mhurd added a subscriber: Edtadros.