Page MenuHomePhabricator

Reduce space between sidebar and content
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

Currently the minimum amount of space between the sidebar and the content is ~68px. This only becomes apparent when the browser window is smaller than 1440px.

image.png (975×1 px, 522 KB)

We want to reduce this minimum amount of space to 46px. I believe this change will require us to also update the value of the breakpoint, which is currently 1440px.

image.png (975×1 px, 522 KB)

Developer Notes

  • This should be as simple as adjusting the @margin-start-content variable in layout-max-width.less. [1]
  • Note that there is 8 pixels of horizontal padding on the tabs and content. This may need to be factored into the calculation.

[1] https://github.com/wikimedia/Vector/blob/f6a1d21af127cd17b35011e403746c9d2411403c/resources/skins.vector.styles/layout-max-width.less#L25

QA Results - Beta

ACStatusDetails
1T259761#6434616

QA Results - Prod

ACStatusDetails
1T259761#6452613

Event Timeline

Jdlrobson set the point value for this task to 2.Aug 19 2020, 5:19 PM

Change 624023 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/Vector@master] Reduce space between sidebar and content

https://gerrit.wikimedia.org/r/624023

Jdrewniak added a subscriber: Jdrewniak.

Change 624023 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Reduce space between sidebar and content

https://gerrit.wikimedia.org/r/624023

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):

QA steps

Reduce browser window width below 1440px.
Confirm spacing between content and left menu is 46px.

margin.png (948×1 px, 436 KB)

Test Result - Prod

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):

QA steps

Reduce browser window width below 1440px.
Confirm spacing between content and left menu is 46px.

Screen Shot 2020-09-10 at 3.36.37 PM.png (1×1 px, 534 KB)

Mhurd updated the task description. (Show Details)
Mhurd added a subscriber: Mhurd.