Page MenuHomePhabricator
Create Task
Maniphest T259774

Improve messaging of block drawer
Closed, ResolvedPublic3 Estimated Story PointsAug 25 2020
Actions

Description

(As proposed in T189717#6214941)

Problem
We tell the user "Your account has been blocked". This is confusing because they probably don't have an account and aren't signed in. This wording should be changed.

mobile-block-not-parsed (2×1 px, 191 KB)

Proposed Solution
We should display messages like:

  • "This IP address has been blocked from editing, but you can still edit by signing in or creating an account."
  • "This IP address has been blocked from editing, but you can still edit by signing in." (if account creation is blocked)
  • For hard IP blocks (where logged in users are still blocked because of their IP address):
    • "This IP address has been blocked from editing, but you may be to edit by signing in." (as they may still be able to edit if their account is exempt)
    • We should also avoid say "you" / "your account" if they are signed in and hard IP blocked.

from T260216#6385885:

Already logged in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.You have been blocked from editing this site.
Partial-Your IP address has been blocked from editing this page. Try editing another page.You have been blocked from editing this page. Try editing another page.

Not logged in, can't avoid block by logging in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.-
Partial-You have been blocked from editing this page. Try editing another page.-

Not logged in, can avoid block by logging in

Can create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in or creating an account.--
PartialYour IP address has been blocked from editing this page. Try logging in or creating an account, or try editing another page.--

Can't create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in if you have an account.--
PartialYour IP address has been blocked from editing this page. Try logging in if you have an account, or try editing another page.--

Details

Due Date
Aug 25 2020, 4:00 AM
SubjectRepoBranchLines +/-
Improve the block drawer message by adding calls to actionmediawiki/extensions/MobileFrontendmaster+49 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

dbarratt created this task.Aug 6 2020, 2:10 AM
dbarratt updated the task description. (Show Details)Aug 6 2020, 2:15 AM
Esanders updated the task description. (Show Details)Aug 6 2020, 2:56 PM
DannyS712 unsubscribed.Aug 6 2020, 5:31 PM
stwalkerster unsubscribed.Aug 8 2020, 9:21 PM
dbarratt mentioned this in T189717: Better handle block reasons on mobile (specifically templates and HTML comments).Aug 11 2020, 3:20 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Aug 11 2020, 5:12 PM
• Niharika triaged this task as Medium priority.Aug 12 2020, 4:39 PM
ARamirez_WMF set the point value for this task to 3.Aug 12 2020, 4:44 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Aug 12 2020, 4:48 PM
• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
• Niharika added a subtask: T260216: Figure out the block messages for mobile .Aug 12 2020, 7:37 PM
• Niharika subscribed.

This ticket is blocked on T260216: Figure out the block messages for mobile .

ARamirez_WMF set Due Date to Aug 25 2020, 4:00 AM.Aug 12 2020, 8:52 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
• Prtksxna updated the task description. (Show Details)Aug 19 2020, 4:25 PM
• Prtksxna mentioned this in T260216: Figure out the block messages for mobile .
• Prtksxna updated the task description. (Show Details)Aug 19 2020, 4:56 PM
Tchanders claimed this task.Aug 19 2020, 5:25 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Tchanders mentioned this in T260932: Return information to help with block message call-to-action in ApiBlockInfoTrait::getBlockDetails.Aug 20 2020, 6:58 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Aug 20 2020, 9:23 PM
gerritbot added a comment.Aug 24 2020, 2:30 PM

Change 621593 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/MobileFrontend@master] Improve the block drawer message by adding calls to action

https://gerrit.wikimedia.org/r/621593

gerritbot added a project: Patch-For-Review.Aug 24 2020, 2:30 PM
dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Aug 24 2020, 8:47 PM
gerritbot added a comment.Aug 24 2020, 9:09 PM

Change 621593 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Improve the block drawer message by adding calls to action

https://gerrit.wikimedia.org/r/621593

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2020, 9:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 24 2020, 10:00 PM
dom_walden moved this task from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.Aug 26 2020, 8:38 AM
dom_walden subscribed.

Already logged in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.You have been blocked from editing this site.
Partial-Your IP address has been blocked from editing this page. Try editing another page.You have been blocked from editing this page. Try editing another page.

True for IP, Username, System ($wgProxyList) and Composite (Username + IP or IP + IP) blocks.

Not logged in, can't avoid block by logging in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.-
Partial-You have been blocked from editing this page. Try editing another page.-

True for IP (hard)blocks.

For $wgProxyList System blocks, the message is:

Your IP address has been blocked from editing devwiki. Try logging in or creating an account.

Even though it is a hardblock. I think because System blocks don't return anything for blockanononly, which means they are treated as softblocks. I will probably raise a bug separately.

Similarly, composite blocks (e.g. IP + IP range) are always treated as softblocks, even if one or all of the blocks are hardblocks. So, the message is either:

Your IP address has been blocked from editing devwiki. Try logging in or creating an account.

if all blocks allow creating account, or

Your IP address has been blocked from editing devwiki. Try logging in if you have an account.

if some or all the blocks block creating accounts.

Not logged in, can avoid block by logging in

Can create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in or creating an account.--
PartialYour IP address has been blocked from editing this page. Try logging in or creating an account, or try editing another page.--

Can't create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in if you have an account.--
PartialYour IP address has been blocked from editing this page. Try logging in if you have an account, or try editing another page.--

True for IP (soft)blocks, soft System blocks (e.g. $wgSoftBlockRanges) and composite blocks if all blocks are softblocks.

Test environments:

dbarratt added a comment.Aug 27 2020, 1:29 AM

I wonder if we should move isHardblock() to AbstractBlock and set a default and override?

dom_walden mentioned this in T261639: System and Composite blocks don't always report correct anonymous value.Aug 31 2020, 2:00 PM
• Prtksxna moved this task from Design Review 🔬 to Done: Q1 (2020-21) 💯 on the Anti-Harassment (The Letter Song) board.Sep 2 2020, 3:29 AM
Tchanders mentioned this in T194200: Mobile web block notice should differentiate between soft and hard IP blocks.Sep 23 2020, 12:50 PM
• Niharika closed this task as Resolved.Oct 2 2020, 7:41 PM
• Niharika closed subtask T260932: Return information to help with block message call-to-action in ApiBlockInfoTrait::getBlockDetails as Resolved.
• Niharika closed subtask T260216: Figure out the block messages for mobile as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL