Page MenuHomePhabricator

Improve messaging of block drawer
Closed, ResolvedPublic3 Estimated Story PointsAug 25 2020

Description

(As proposed in T189717#6214941)

Problem
We tell the user "Your account has been blocked". This is confusing because they probably don't have an account and aren't signed in. This wording should be changed.

Proposed Solution
We should display messages like:

  • "This IP address has been blocked from editing, but you can still edit by signing in or creating an account."
  • "This IP address has been blocked from editing, but you can still edit by signing in." (if account creation is blocked)
  • For hard IP blocks (where logged in users are still blocked because of their IP address):
    • "This IP address has been blocked from editing, but you may be to edit by signing in." (as they may still be able to edit if their account is exempt)
    • We should also avoid say "you" / "your account" if they are signed in and hard IP blocked.

from T260216#6385885:

Already logged in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.You have been blocked from editing this site.
Partial-Your IP address has been blocked from editing this page. Try editing another page.You have been blocked from editing this page. Try editing another page.

Not logged in, can't avoid block by logging in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.-
Partial-You have been blocked from editing this page. Try editing another page.-

Not logged in, can avoid block by logging in

Can create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in or creating an account.--
PartialYour IP address has been blocked from editing this page. Try logging in or creating an account, or try editing another page.--

Can't create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in if you have an account.--
PartialYour IP address has been blocked from editing this page. Try logging in if you have an account, or try editing another page.--

Event Timeline

dbarratt created this task.Aug 6 2020, 2:10 AM
dbarratt updated the task description. (Show Details)Aug 6 2020, 2:15 AM
Esanders updated the task description. (Show Details)Aug 6 2020, 2:56 PM
Niharika triaged this task as Medium priority.Aug 12 2020, 4:39 PM
ARamirez_WMF set the point value for this task to 3.Aug 12 2020, 4:44 PM
ARamirez_WMF set Due Date to Aug 25 2020, 4:00 AM.Aug 12 2020, 8:52 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
Prtksxna updated the task description. (Show Details)Aug 19 2020, 4:56 PM

Change 621593 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/MobileFrontend@master] Improve the block drawer message by adding calls to action

https://gerrit.wikimedia.org/r/621593

Change 621593 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Improve the block drawer message by adding calls to action

https://gerrit.wikimedia.org/r/621593

dom_walden added a subscriber: dom_walden.

Already logged in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.You have been blocked from editing this site.
Partial-Your IP address has been blocked from editing this page. Try editing another page.You have been blocked from editing this page. Try editing another page.

True for IP, Username, System ($wgProxyList) and Composite (Username + IP or IP + IP) blocks.

Not logged in, can't avoid block by logging in (account creation status irrelevant)

IP block (anon only)IP block (hardblock)Account block
Sitewide-Your IP address has been blocked from editing this site.-
Partial-You have been blocked from editing this page. Try editing another page.-

True for IP (hard)blocks.

For $wgProxyList System blocks, the message is:

Your IP address has been blocked from editing devwiki. Try logging in or creating an account.

Even though it is a hardblock. I think because System blocks don't return anything for blockanononly, which means they are treated as softblocks. I will probably raise a bug separately.

Similarly, composite blocks (e.g. IP + IP range) are always treated as softblocks, even if one or all of the blocks are hardblocks. So, the message is either:

Your IP address has been blocked from editing devwiki. Try logging in or creating an account.

if all blocks allow creating account, or

Your IP address has been blocked from editing devwiki. Try logging in if you have an account.

if some or all the blocks block creating accounts.

Not logged in, can avoid block by logging in

Can create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in or creating an account.--
PartialYour IP address has been blocked from editing this page. Try logging in or creating an account, or try editing another page.--

Can't create account

IP block (anon only)IP block (hardblock)Account block
SitewideYour IP address has been blocked from editing this site. Try logging in if you have an account.--
PartialYour IP address has been blocked from editing this page. Try logging in if you have an account, or try editing another page.--

True for IP (soft)blocks, soft System blocks (e.g. $wgSoftBlockRanges) and composite blocks if all blocks are softblocks.

Test environments:

I wonder if we should move isHardblock() to AbstractBlock and set a default and override?