Page MenuHomePhabricator

Fed Props test & demo systems broken due to lib/WikibaseLib.php removal
Closed, ResolvedPublic

Description

The test system is currently loading lib/WikibaseLib.php (which means loading this file is probably documented somewhere and other wikibases may also have this line.

It was removed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/618342

It should perhaps we readded as an empty file just to avoid the issue.

Warning: require_once(/var/www/html/extensions/Wikibase/lib/WikibaseLib.php): failed to open stream: No such file or directory in /var/www/html/LocalSettings.php on line 52

Fatal error: require_once(): Failed opening required '/var/www/html/extensions/Wikibase/lib/WikibaseLib.php' (include_path='/var/www/html/vendor/pear/console_getopt:/var/www/html/vendor/pear/mail:/var/www/html/vendor/pear/mail_mime:/var/www/html/vendor/pear/net_smtp:/var/www/html/vendor/pear/net_socket:/var/www/html/vendor/pear/pear-core-minimal/src:/var/www/html/vendor/pear/pear_exception:.:/usr/local/lib/php') in /var/www/html/LocalSettings.php on line 52

There was a change to update the fed props systems LS.php files https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/616071
And that is already merged in master but has not yet been deployed to any of the test systems

Points:

  • Restore the WikibaseLib.php file for the people that use it (could be filed as a separate task?)
  • Update the fed props test systems to use the merged in master config

Event Timeline

Addshore created this task.Aug 6 2020, 9:25 AM
Restricted Application added a project: User-Addshore. · View Herald TranscriptAug 6 2020, 9:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 618721 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Add empty WikibaseLib.php

https://gerrit.wikimedia.org/r/618721

Which test system is this task even about? The wikidata-dev VM list on Horizon looks like there are at least three federated properties test systems. (There doesn’t seem to be any documentation for them on Wikitech.)

On the wikidata-federated-properties instance, the wikibase/wikibase:1.33-bundle Docker container has this in its LocalSettings.php:

## Wikibase
# Load Wikibase repo, client & lib with the example / default settings.
require_once "$IP/extensions/Wikibase/lib/WikibaseLib.php";
require_once "$IP/extensions/Wikibase/repo/Wikibase.php";
require_once "$IP/extensions/Wikibase/repo/ExampleSettings.php";
require_once "$IP/extensions/Wikibase/client/WikibaseClient.php";
require_once "$IP/extensions/Wikibase/client/ExampleSettings.php";

Does anyone know why this is loading WikibaseLib.php directly? I don’t think this is in the installation instructions.

Addshore renamed this task from Fed Props test system broken to Fed Props test system broken due to lib/WikibaseLib.php removal.Aug 6 2020, 10:22 AM
Addshore triaged this task as High priority.Aug 6 2020, 10:25 AM

Which test system is this task even about? The wikidata-dev VM list on Horizon looks like there are at least three federated properties test systems. (There doesn’t seem to be any documentation for them on Wikitech.)

Docs are at https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/build/federated-properties/README.md but they do indeed only talk about one of the test systems on cloud vps currently.
I'll write a patch to fix that.
All 3 tests systems use this ansible playbook

Addshore updated the task description. (Show Details)Aug 6 2020, 10:27 AM

Mentioned in SAL (#wikimedia-cloud) [2020-08-06T10:52:38Z] <Lucas_WMDE> wikidata-federated-properties ansible-playbook fedProps.yml --limit wikidata-federated-properties.wikidata-dev.eqiad.wmflabs (relog with T259782)

Addshore renamed this task from Fed Props test system broken due to lib/WikibaseLib.php removal to Fed Props test & demo systems broken due to lib/WikibaseLib.php removal.EditedAug 6 2020, 1:08 PM

Updated the description to reflect that the demo systems will also be broken.
I'll go and run it against them now, and also update the wikitech docs

Change 618750 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] FP: Update ansible README for demo instances

https://gerrit.wikimedia.org/r/618750

Mentioned in SAL (#wikimedia-cloud) [2020-08-06T14:15:19Z] <addshore> ansible-playbook fedProps.yml --limit fedprops-euspecies.wikidata-dev.eqiad.wmflabs # T259782

Mentioned in SAL (#wikimedia-cloud) [2020-08-06T14:15:29Z] <addshore> ansible-playbook fedProps.yml --limit fedprops-opennext.wikidata-dev.eqiad.wmflabs # T259782

Change 618759 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] FP: ansible, also run composer update

https://gerrit.wikimedia.org/r/618759

Addshore updated the task description. (Show Details)Aug 6 2020, 2:16 PM

Change 618721 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add empty WikibaseLib.php

https://gerrit.wikimedia.org/r/618721

Change 618750 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Update ansible README for demo instances

https://gerrit.wikimedia.org/r/618750

Change 618759 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: ansible, also run composer update

https://gerrit.wikimedia.org/r/618759

Addshore closed this task as Resolved.Thu, Sep 3, 8:54 AM
Addshore removed a project: Patch-For-Review.