Page MenuHomePhabricator

Deploy the new Vue.js search experience to the Beta-Cluster and Test Wikipedia
Closed, ResolvedPublic3 Estimated Story Points

Description

This task encompasses the work to ship the new Vue.js-powered search experience to the initial deployment targets, the Beta-Cluster and Test Wikipedia (testwiki). These wikis are more forgiving audiences for in-development features. So long as the feature doesn't break development workflows of someone else, it is usually a welcoming place for change. In the case of search, as soon as it is usable, it should be considered shippable to these wikis.

Configuration

// Disable the old search experience from Core. Vector will provide its own in "Latest" mode (v2) only.
$wgVectorUseCoreSearch = false;

Acceptance criteria

  • mediawiki-config is revised with the new configuration
  • The new Vue.js search experience is deployed to beta cluster on: 11th feb 2021**
  • A brief announcement is shared on #front-end and #humansoftheweb channels just to alert folks that stuff is up.
  • The error logs are checked for new errors on the Beta-Cluster and testwiki (review the chores page for links).
  • The new Vue.js search experience is testwiki but nowhere on: TBD**
  • The new vue.js search experience is deployed to officewik on: TBD**
  • The Performance team, Core Platform API team, and Edward are notified so they can evaluate in a production-like environment if wanted.

Pre-deployment

  • inform editing, growth, and search teams prior to deployment to office and test wiki based on testing on the beta cluster

QA

Beta cluster QA steps to accomplish above ^

Functionality:
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog
  2. Select search widget
  3. Ensure search widget expands according to dimensions given in https://phabricator.wikimedia.org/T270202 F32194620
  4. Type AL in search box
  5. Ensure results appear and are accompanied by images and descriptions (note: not all results are required to have images and descriptions)
  6. Ensure that within the results list the remainder of the results (outside of the searched term) is bolded. For this example, this would mean anything but “AL” would appear as bolded
  7. Select the results “Albert Einstein”
  8. Ensure you are navigated to the Albert Einstein article.
  9. Ensure search bar returns to its pre-loaded form
  10. Click within the search bar
  11. Click outside the search bar
  12. Hover on the search bar
  13. The search button should appear on hover
Window size
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user
  2. Change to a few window sizes between 500px and 2500px
  3. Ensure search there are no visual bugs or inconsistencies at those sizes
Browser list
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user on the list of browsers below
  2. Spot-check to ensure search functionality behaves as expected

Spot-checking selected with at least one Grade A & Grade B browsers from each major browser family

(from https://turnilo.wikimedia.org/#pageviews_daily/4/N4IgbglgzgrghgGwgLzgFwgewHYgFwhpwBGCApiADTjTxKoY4DKZaG2A5lPqAMaYIEcAA5QyAJUwB3bngBmiMQF9qGALZlkOCgQCiaXgHoAqgBUAwlRByICNGQBOsgNqg0AT2E7CEDVYdkcvggAPoh6hSqvmQACo5YACYuoAkwDuhYuAQxAMwADAAiVlD2wvgAtACMqp7eQvYlIEoAuiputcElDhCc/oHBcBxk2GjhHdRwvIxZID1WYIgwZC4gMGIOIM3U2Jho+AoIypTtXp1o3b3UAUEEk7zLUCEaaAAWmAlWk9PBc9QLCEsVgllgBrNCYMpbEA7PbyRRkFrUKDCJBoZKEDoELo9DhWBLRbBQTLBeAhYgOaTrEIKNS2dzFTAOWGga7BSBkKQhfgwEZWDynLHxZZ4iABKbEgjAqD3bD4y4gLzdd7BJrUJC02EAVjybQxApA2Pl+I0hIlqzgZIpMkcTzgACtGQymTwQKyCOzOdzeTV9esIMLqPixd9JcsZXLcdRFYkVSoQOqIFrEQahejro5hvc2f7PZgeXtqHJGWp0C7+d5gQoYHZ5otvKq9d4NHBYAEmlDhD1sGQEgUCUScC4O12e0xGbCaByuXneUogA==)

Chrome:

  • 87
  • 85
  • 70

Firefox

  • 85
  • 76
  • 52

Safari

  • 14
  • 11

IE

  • 20

Opera

  • 73

Yandex

  • 46.7

Edge

  • 87
  • 18
Instrumentation (To be done in T274869: Instrumentation QA for new search widget)
  1. Ensure events recorded as expected
  2. Ensure A/B bucketing functioning as expected

Steps TBD by @MNeisler

Editing
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user
  2. Enter source editor and ensure you can still search without issue
  3. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user
  4. Enter visual editor and ensure you can still search without issue

Sign off steps

  • Make sure the appropriate dashboards are setup T250336.

QA Results - Beta

Functionality
Window Size
ACStatusDetails
1T259798#6854792
Browser List
Editing
ACStatusDetails
1T259798#6846199
2T259798#6846199

Related Objects

StatusSubtypeAssignedTask
OpenNone
Resolvedovasileva
ResolvedVolker_E
Resolvedphuedx
Resolved eprodromou
ResolvedEvanProdromou
ResolvedPeter.ovchyn
ResolvedPeter.ovchyn
ResolvedPeter.ovchyn
Resolved eprodromou
ResolvedPeter.ovchyn
Resolveddaniel
Resolveddaniel
Resolveddaniel
Resolvedholger.knust
Resolvedholger.knust
Resolvedholger.knust
OpenNone
OpenNone
OpenNone
ResolvedSpikeovasileva
Resolvedphuedx
ResolvedJdrewniak
Resolvedalexhollender
Resolvedovasileva
ResolvedJdlrobson
ResolvedJdrewniak
ResolvedJdrewniak
ResolvedNiedzielski
ResolvedMNeisler
ResolvedMNeisler
Resolvedovasileva
Resolvedphuedx
Resolvedovasileva
Resolvedovasileva
Resolvednray
OpenNone
Openalexhollender
OpenJdlrobson
OpenMNeisler
Resolvedovasileva
ResolvedEdtadros
DeclinedNone
DeclinedNone
ResolvedJdrewniak
ResolvedJdrewniak
Opennnikkhoui
Resolvednnikkhoui
ResolvedJdlrobson
Duplicateovasileva
ResolvedMNeisler
ResolvedVolker_E
Resolvedphuedx
Resolvedovasileva
Resolvedovasileva
Resolvedsbassett
Openovasileva

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ovasileva updated the task description. (Show Details)
ovasileva set the point value for this task to 3.Dec 9 2020, 6:24 PM
Jdlrobson updated the task description. (Show Details)

Change 664531 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[operations/mediawiki-config@master] vector: Enable WVUI search on testwiki

https://gerrit.wikimedia.org/r/664531

Change 664531 merged by jenkins-bot:
[operations/mediawiki-config@master] vector: Enable WVUI search on test wikis

https://gerrit.wikimedia.org/r/664531

Change 664548 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[operations/mediawiki-config@master] testwikis: Inherit from desktop-improvements

https://gerrit.wikimedia.org/r/664548

Change 664259 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "vector: Enable WVUI search on test wikis"

https://gerrit.wikimedia.org/r/664259

Change 664548 abandoned by Phuedx:
[operations/mediawiki-config@master] testwikis: Inherit from desktop-improvements

Reason:

https://gerrit.wikimedia.org/r/664548

Change 664259 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "vector: Enable WVUI search on test wikis"

https://gerrit.wikimedia.org/r/664259

Change 664552 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[operations/mediawiki-config@master] vector: Enable WVUI search on test wikis

https://gerrit.wikimedia.org/r/664552

Change 664552 merged by jenkins-bot:
[operations/mediawiki-config@master] vector: Enable WVUI search on test wikis

https://gerrit.wikimedia.org/r/664552

Change 664260 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "vector: Enable WVUI search on test wikis"

https://gerrit.wikimedia.org/r/664260

Change 664260 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "vector: Enable WVUI search on test wikis"

https://gerrit.wikimedia.org/r/664260

Change 664793 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[operations/mediawiki-config@master] Revert "Revert "vector: Enable WVUI search on test wikis""

https://gerrit.wikimedia.org/r/664793

Change 664794 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[operations/mediawiki-config@master] vector: Enable search treatment AB test on test wikis

https://gerrit.wikimedia.org/r/664794

Change 664793 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Revert "vector: Enable WVUI search on test wikis""

https://gerrit.wikimedia.org/r/664793

Mentioned in SAL (#wikimedia-operations) [2021-02-17T12:07:41Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 7872251778b65cb03eb5457f1b901d208d514609: Revert "Revert "vector: Enable WVUI search on test wikis"" (T259798) (duration: 01m 25s)

Change 664794 merged by jenkins-bot:
[operations/mediawiki-config@master] vector: Enable search treatment AB test on test wikis

https://gerrit.wikimedia.org/r/664794

Mentioned in SAL (#wikimedia-operations) [2021-02-17T12:10:35Z] <urbanecm@deploy1001> Synchronized dblists/desktop-improvements.dblist: 7872251778b65cb03eb5457f1b901d208d514609: Revert "Revert "vector: Enable WVUI search on test wikis"" (T259798) (duration: 01m 09s)

Mentioned in SAL (#wikimedia-operations) [2021-02-17T12:14:02Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 6eeee95e090408c8bd35d14c2f76e3afd8a59048: vector: Enable search treatment AB test on test wikis (T259798) (duration: 01m 08s)

Functionality:

Status: ❓ Need More Info
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog
  2. Select search widget
  3. AC1: Ensure search widget expands according to dimensions given in https://phabricator.wikimedia.org/T270202 F32194620
✅ Max Dimensions
✅ Icon Dimensions
✅ Text Top/Bottom Padding
❓ Icon Left/Right Padding
Horizontal padding appears to be 8px instead of 9px, is this acceptable?
  1. Type AL in search box
  2. AC2: Ensure results appear and are accompanied by images and descriptions (note: not all results are required to have images and descriptions)

  1. AC3: Ensure that within the results list the remainder of the results (outside of the searched term) is bolded. For this example, this would mean anything but “AL” would appear as bolded
  2. See AC2 above.
  3. Select the results “Albert Einstein”
  4. AC4: Ensure you are navigated to the Albert Einstein article.

  1. AC5: Ensure search bar returns to its pre-loaded form
  2. See AC4 above.
  3. Click within the search bar
  4. Click outside the search bar
  5. Hover on the search bar
  6. AC6: The search button should appear on hover

Window size

Test Result - Beta|Prod

Status: ❌ FAIL
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user
  2. Change to a few window sizes between 500px and 2500px
  3. ❌ AC1: Ensure search there are no visual bugs or inconsistencies at those sizes
ResultWidth (px)Images Comments
500
The text on the Search button is not centered
750
1000
1500
2000
2500
Browser list

Test Result - Beta|Prod

Status: ❌ FAIL
Environment: beta
OS: See Table
Browser: See Table
Device: MBP
Emulated Device: Browserstack

Test Artifact(s):

QA Steps
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user on the list of browsers below
  2. Spot-check to ensure search functionality behaves as expected
ACBrowser FamilyVersionOSArtifact
✅ AC1Chrome
87Win10
85Win10
70Win10
✅ AC2Firefox
85Win10
76Win10
52Win10
✅ AC3Safari
14macOS Big Sur
11macOS High Sierra
❌ AC4IE
11Win10
✅ AC5Opera
74Win10
66Win10
❌ AC6Yandex
14.12Win10
✅ AC7Edge
87Win10
18Win10
Editing

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user
  2. ✅ AC1: Enter source editor and ensure you can still search without issue

  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/African_wild_dog as a logged-in user
  2. ✅ AC2: Enter visual editor and ensure you can still search without issue

Edtadros added subscribers: ovasileva, Edtadros.

@ovasileva please take a look at the following (they are linked in the description as well):

Functionality
ACStatusDetails
1T259798#6846157
Window Size
ACStatusDetails
1T259798#6846159
Browser List
ACStatusDetails
4T259798#6846197
6T259798#6846197

@ovasileva please take a look at the following (they are linked in the description as well):

Functionality
ACStatusDetails
1T259798#6846157
Window Size
ACStatusDetails
1T259798#6846159

These seem ok to me. @alexhollender - could you take a look and confirm?

Browser List
ACStatusDetails
4T259798#6846197
6T259798#6846197

@Edtadros - this is correct behavior. On these browsers, we're expecting to see the fallback search which seems to be working properly based on your screenshots

@ovasileva please take a look at the following (they are linked in the description as well):

Functionality
ACStatusDetails
1T259798#6846157

for now let's leave this as-is (i.e. Pass)

Window Size
ACStatusDetails
1T259798#6846159

@ovasileva my thinking is that we should handle this in a follow-up task. I'm thinking of 500px as "minimally supported", so even though search looks a little funky it is still usable and therefore not a blocker.

All done here, will set up a follow-up task for the point made above