⚓ T259811 Reply widget's white background is inconsistent between source and visual mode

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (18920ed63)	mediawiki/extensions/VisualEditor	master	+1 -1
	TargetWidget: Use a white background, not transparent	VisualEditor/VisualEditor	master	+8 -0

matmarex created this task.Aug 6 2020, 3:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2020, 3:47 PM

matmarex added a project: Editing-team (Kanban Board).Aug 6 2020, 3:47 PM

Change 618778 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] TargetWidget: Use a white background, not transparent

https://gerrit.wikimedia.org/r/618778

gerritbot added a project: Patch-For-Review.Aug 6 2020, 3:48 PM

• ppelberg subscribed.Aug 6 2020, 4:48 PM

Good spot, @matmarex. I agree with the change you are proposing.

Next steps

@iamjessklein can you review what Bartosz is proposing in the task description and share a quick "thumbs up/down" ?

• ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Aug 6 2020, 7:04 PM

• ppelberg added a project: Editing Design.

• ppelberg moved this task from 📚 Backlog to 📐 Doing on the Editing Design board.

• ppelberg moved this task from Code Review to Design Review on the Editing-team (Kanban Board) board.

I filed and fixed this in T259828

Esanders merged a task: T259828: Visual mode needs a white background.Aug 7 2020, 1:32 PM

Change 618778 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TargetWidget: Use a white background, not transparent

https://gerrit.wikimedia.org/r/618778

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2020, 3:10 PM

+1 nice @Esanders and @matmarex

🐿 ship it.

• iamjessklein moved this task from 📐 Doing to 👀 Needs PM Input on the Editing Design board.Aug 10 2020, 4:21 PM

Change 619324 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (18920ed63)

https://gerrit.wikimedia.org/r/619324

gerritbot added a project: Patch-For-Review.Aug 10 2020, 4:40 PM

Change 619324 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (18920ed63)

https://gerrit.wikimedia.org/r/619324

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 5:10 PM

matmarex moved this task from Design Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 10 2020, 5:34 PM

matmarex added a project: Skipped QA.

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 10 2020, 6:00 PM

• ppelberg closed this task as Resolved.Aug 11 2020, 1:54 AM

• ppelberg claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 11 2020, 1:54 AM

Reply widget's white background is inconsistent between source and visual mode
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

	F31968091: image.png
	Aug 6 2020, 3:47 PM

	F31968076: image.png
	Aug 6 2020, 3:47 PM

	F31968097: image.png
	Aug 6 2020, 3:47 PM

	F31968084: image.png
	Aug 6 2020, 3:47 PM

Reply widget's white background is inconsistent between source and visual modeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Reply widget's white background is inconsistent between source and visual mode
Closed, ResolvedPublic
Actions