MediaWiki version: 1.36.0-wmf.3
PHP Notice: Undefined index: href
A large spike - around 600 - of these on kowiki several hours after 1.36.0-wmf.3 deploy.
Reproducible at the given URL. Not clear that it's creating user-facing breakage, and I'm reluctant to block the train over the weekend for this, but I'll probably roll back if it crops up at any volume again.
#0 /srv/mediawiki/php-1.36.0-wmf.3/extensions/DiscussionTools/includes/ThreadItem.php(96): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.3/extensions/DiscussionTools/includes/ApiDiscussionTools.php(54): MediaWiki\Extension\DiscussionTools\ThreadItem->getTranscludedFrom()
#2 /srv/mediawiki/php-1.36.0-wmf.3/includes/api/ApiMain.php(1593): MediaWiki\Extension\DiscussionTools\ApiDiscussionTools->execute()
#3 /srv/mediawiki/php-1.36.0-wmf.3/includes/api/ApiMain.php(529): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.36.0-wmf.3/includes/api/ApiMain.php(500): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.36.0-wmf.3/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.36.0-wmf.3/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ThreadItem: Fix "Notice: Undefined index: href" | mediawiki/extensions/DiscussionTools | master | +2 -1 |
Also looks like it might well predate wmf.3, from a cursory glance at commits on that file. @Esanders - any thoughts?
Given that rEDTO includes/ThreadItem.php didn’t change in the last two weeks, it seems more likely that something is broken (or deliberately changed without notice) on the Parsoid side.
At first glance, I wold say, unlikely caused by Parsoid rollout. I will let @Esanders take a look first.
We enabled DiscussionTools on kowiki in a config deploy, the reports probably started then. Any impact should be limited to only users who opted in to the beta feature.
I've looked at this now. This is completely harmless and only causes log noise – we missed an isset(). It's triggered by pages that use a parser function directly, e.g. https://ko.wikipedia.org/w/index.php?title=위키백과:사랑방_(기술)&oldid=25062245&action=edit
Change 619002 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] ThreadItem: Fix "Notice: Undefined index: href"
Change 619002 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ThreadItem: Fix "Notice: Undefined index: href"