Disable page previews (popups) in all VE surfaces, including DiscussionTools
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Aug 7 2020, 2:22 PM

Description

The page previews extension can conflict with the VE link inspector. It has always been disabled in the VE article editor as it only looks for links inside #mw-content-text and the VE target is a sibling of that.

Link focused and hovered in DiscussionTools:

Details

	Subject	Repo	Branch	Lines +/-
	Disable popups inside VE surfaces	mediawiki/extensions/Popups	master	+4 -3

Customize query in gerrit

Event Timeline

Esanders created this task.Aug 7 2020, 2:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2020, 2:22 PM

Change 618994 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Popups@master] Disable popups on VE links

https://gerrit.wikimedia.org/r/618994

gerritbot added a project: Patch-For-Review.Aug 7 2020, 2:34 PM

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Aug 7 2020, 2:34 PM

Jdlrobson added a project: Web-Team-Backlog (Tracking).Aug 7 2020, 2:41 PM

Change 618994 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Disable popups inside VE surfaces

https://gerrit.wikimedia.org/r/618994

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 10 2020, 10:00 PM

Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 10 2020, 10:09 PM

Esanders added a project: Skipped QA.

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 10:10 PM

• ppelberg closed this task as Resolved.Aug 11 2020, 1:52 AM

• ppelberg claimed this task.

Disable page previews (popups) in all VE surfaces, including DiscussionToolsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Disable page previews (popups) in all VE surfaces, including DiscussionTools
Closed, ResolvedPublic
Actions