Page MenuHomePhabricator
Create Task
Maniphest T259910

$revid should be removed from DataAccess::fetchPageContent
Closed, ResolvedPublic
Actions

Description

No code in parsoid passes $revid != 0 to DataAccess::fetchPageContent, because by-id template expansion, etc, isn't a feature of wikitext semantics. We do by-id fetches to create the initial PageContent, but that doesn't use DataAccess::fetchPageContent (even in the API case, where you could argue we could be reusing code).

Removing this unused parameter would also allow us to simplify the constructor for DataAccess, removing the RevisionStore.

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to v0.13.0-a7mediawiki/vendormaster+1 K -1 K
Remove $revid parameter from DataAccess::fetchPageContentmediawiki/services/parsoidmaster+12 -40
Customize query in gerrit

Event Timeline

cscott created this task.Aug 7 2020, 6:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2020, 6:16 PM
gerritbot added a comment.Aug 7 2020, 7:03 PM

Change 619029 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Remove $revid parameter from DataAccess::fetchPageContent

https://gerrit.wikimedia.org/r/619029

gerritbot added a project: Patch-For-Review.Aug 7 2020, 7:03 PM
ssastry triaged this task as Medium priority.Aug 10 2020, 6:22 PM
ssastry moved this task from Needs Triage to Current & Upcoming Work on the Parsoid board.
ssastry added a project: Parsing-Active-Work.
ssastry moved this task from Incoming Work (but not yet ready) to Doing (Other Work) on the Parsing-Active-Work board.Aug 13 2020, 10:49 PM
gerritbot added a comment.Aug 18 2020, 4:38 AM

Change 619029 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove $revid parameter from DataAccess::fetchPageContent

https://gerrit.wikimedia.org/r/619029

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2020, 5:10 AM
gerritbot added a comment.Aug 24 2020, 8:10 PM

Change 622176 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a7

https://gerrit.wikimedia.org/r/622176

gerritbot added a project: Patch-For-Review.Aug 24 2020, 8:10 PM
gerritbot added a comment.Aug 24 2020, 10:16 PM

Change 622176 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a7

https://gerrit.wikimedia.org/r/622176

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2020, 11:10 PM
ssastry closed this task as Resolved.Sep 24 2020, 6:33 PM
ssastry assigned this task to cscott.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL